Re: [PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

2020-11-20 Thread Gedare Bloom
On Fri, Nov 20, 2020 at 9:28 AM Sebastian Huber wrote: > > On 20/11/2020 17:15, Gedare Bloom wrote: > > >> +static bool _Partition_Is_buffer_size_aligned( size_t buffer_size ) > > Nit: I never saw this before, but this isn't what "aligned" means. > > Aligned means you start something at a specific

Re: [PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

2020-11-20 Thread Sebastian Huber
On 20/11/2020 17:15, Gedare Bloom wrote: +static bool _Partition_Is_buffer_size_aligned( size_t buffer_size ) Nit: I never saw this before, but this isn't what "aligned" means. Aligned means you start something at a specific multiple. This is checking if the buffer_size is a multiple of the poi

Re: [PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

2020-11-20 Thread Gedare Bloom
On Fri, Nov 20, 2020 at 4:16 AM Sebastian Huber wrote: > > It is only used by rtems_partition_create(). Fix integer type. > --- > cpukit/include/rtems/rtems/partimpl.h | 7 --- > cpukit/rtems/src/partcreate.c | 5 + > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --gi

[PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

2020-11-20 Thread Sebastian Huber
It is only used by rtems_partition_create(). Fix integer type. --- cpukit/include/rtems/rtems/partimpl.h | 7 --- cpukit/rtems/src/partcreate.c | 5 + 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h b/cpukit/include/rtems/rtems