Re: [PATCH 12/15] HiFive1: add UART support

2017-08-21 Thread Denis Obrezkov
2017-08-17 17:21 GMT+02:00 Gedare Bloom : > Remove the extra blank lines, and consider adding some helper > functions (for enable/disable UARTx, for example) > > On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov > wrote: > > --- > > .../libbsp/riscv32/hifive1/console/fe310-uart.c| 215 > +

Re: [PATCH 12/15] HiFive1: add UART support

2017-08-17 Thread Gedare Bloom
Remove the extra blank lines, and consider adding some helper functions (for enable/disable UARTx, for example) On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov wrote: > --- > .../libbsp/riscv32/hifive1/console/fe310-uart.c| 215 > + > .../libbsp/riscv32/hifive1/include/

[PATCH 12/15] HiFive1: add UART support

2017-08-16 Thread Denis Obrezkov
--- .../libbsp/riscv32/hifive1/console/fe310-uart.c| 215 + .../libbsp/riscv32/hifive1/include/fe310-gpio.h| 41 .../libbsp/riscv32/hifive1/include/fe310-uart.h| 38 3 files changed, 294 insertions(+) create mode 100644 c/src/lib/libbsp/riscv32/hifive1/