On 11/26/2014 09:22 AM, Gedare Bloom wrote:
Just a general comment that I think it better to have the last line be
the "good" return value, that is, check for an error and return EIO,
otherwise default to return RC_OK. Usually you want to have errors
cause short-circuits, while non-error executio
Just a general comment that I think it better to have the last line be
the "good" return value, that is, check for an error and return EIO,
otherwise default to return RC_OK. Usually you want to have errors
cause short-circuits, while non-error execution proceeds to the end.
On Tue, Nov 25, 2014 a
From: Josh Oguin
CodeSonar flagged this as a case where the return value from fat_sync()
was not used. Now it is used to return pass/fail to the caller.
---
cpukit/libfs/src/dosfs/msdos_file.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/cpukit/libfs/src/dosfs/msdos_fi
