Re: [PATCH 1/6] shell: Move line editor output check

2022-04-06 Thread Sebastian Huber
On 06/04/2022 11:50, Chris Johns wrote: @@ -869,6 +856,7 @@ bool rtems_shell_main_loop( int line = 0; FILE *stdinToClose = NULL; FILE *stdoutToClose = NULL; + FILE *line_editor_output; lineEditorOutput or line_editor_output? I prefer the R

Re: [PATCH 1/6] shell: Move line editor output check

2022-04-06 Thread Chris Johns
On 6/4/22 5:17 pm, Sebastian Huber wrote: > Move call to isatty() to caller of rtems_shell_line_editor(). This > avoids a dependency on isatty() in rtems_shell_line_editor(). > --- > cpukit/libmisc/shell/shell.c | 82 +--- > 1 file changed, 38 insertions(+), 44 del

[PATCH 1/6] shell: Move line editor output check

2022-04-06 Thread Sebastian Huber
Move call to isatty() to caller of rtems_shell_line_editor(). This avoids a dependency on isatty() in rtems_shell_line_editor(). --- cpukit/libmisc/shell/shell.c | 82 +--- 1 file changed, 38 insertions(+), 44 deletions(-) diff --git a/cpukit/libmisc/shell/shell.c