On Mon, Oct 13, 2014 at 7:03 PM, Joel Sherrill
wrote:
>
> On 10/13/2014 11:45 AM, Hesham Moustafa wrote:
>
> Missed patch?
>
> Yep. Committed now. This should address a bunch of the or1ksim
> build warnings. I fixed another in console/uart.c for an unused
> variable.
>
> Thanks. There is another
On 10/13/2014 11:45 AM, Hesham Moustafa wrote:
> Missed patch?
>
Yep. Committed now. This should address a bunch of the or1ksim
build warnings. I fixed another in console/uart.c for an unused
variable.
Starting another build of all BSPs to see if I fixed all
"-Wunused-variables"
cases.
Thanks.
>
Missed patch?
On Fri, Oct 10, 2014 at 7:23 PM, Hesham ALMatary
wrote:
> ---
> c/src/lib/libcpu/or1k/shared/cache/cache.c | 16
> c/src/lib/libcpu/or1k/shared/cache/cache_.h | 1 +
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/c/src/lib/libcpu/or1k/shared
---
c/src/lib/libcpu/or1k/shared/cache/cache.c | 16
c/src/lib/libcpu/or1k/shared/cache/cache_.h | 1 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/c/src/lib/libcpu/or1k/shared/cache/cache.c
b/c/src/lib/libcpu/or1k/shared/cache/cache.c
index 039be36..afc8859
On 10/10/2014 12:04 PM, Gedare Bloom wrote:
> Just one note, I prefer to see addresses cast to uintptr_t.
+1
Assuming sizeof(void *) == sizeof(uint32_t) can be a problem in the
future.
If the value is used more than once, it often makes sense to declare
a local variable of the proper type.
> On
Just one note, I prefer to see addresses cast to uintptr_t.
On Fri, Oct 10, 2014 at 12:44 PM, Hesham ALMatary
wrote:
> ---
> c/src/lib/libcpu/or1k/shared/cache/cache.c | 16
> c/src/lib/libcpu/or1k/shared/cache/cache_.h | 1 +
> 2 files changed, 9 insertions(+), 8 deletions(-)
---
c/src/lib/libcpu/or1k/shared/cache/cache.c | 16
c/src/lib/libcpu/or1k/shared/cache/cache_.h | 1 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/c/src/lib/libcpu/or1k/shared/cache/cache.c
b/c/src/lib/libcpu/or1k/shared/cache/cache.c
index 039be36..d38b572
