Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Cillian O'Donnell
On Fri, 27 Apr 2018, 08:32 Chris Johns, wrote: > On 27/04/2018 17:21, Cillian O'Donnell wrote: > > On Fri, 27 Apr 2018, 04:48 Chris Johns, > > wrote: > > > > On 27/04/2018 08:51, Joel Sherrill wrote: > > > > > >// Create the set of desired symbols. >

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Chris Johns
On 27/04/2018 17:21, Cillian O'Donnell wrote: > On Fri, 27 Apr 2018, 04:48 Chris Johns, > wrote: > > On 27/04/2018 08:51, Joel Sherrill wrote: > > > >        // Create the set of desired symbols. > >        SymbolsToAnalyze = new Coverage::DesiredSymbols()

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Cillian O'Donnell
On Fri, 27 Apr 2018, 04:48 Chris Johns, wrote: > On 27/04/2018 08:51, Joel Sherrill wrote: > > > >// Create the set of desired symbols. > >SymbolsToAnalyze = new Coverage::DesiredSymbols(); > > - SymbolsToAnalyze->load( symbolsFile ); > > > > > > I am having trouble seeing wh

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-26 Thread Chris Johns
On 27/04/2018 08:51, Joel Sherrill wrote: > >    // Create the set of desired symbols. >    SymbolsToAnalyze = new Coverage::DesiredSymbols(); > -  SymbolsToAnalyze->load( symbolsFile ); > > > I am having trouble seeing what happened to the DesiredSymbols class. Is > it no longer nee

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-26 Thread Joel Sherrill
> > 8 insertions(+), 11 deletions(-) > create mode 100644 tester/covoar/SymbolSet.cpp > create mode 100644 tester/covoar/SymbolSet.h > create mode 100644 tester/covoar/SymbolSetReader.cpp > create mode 100644 tester/covoar/SymbolSetReader.h > > diff --git a/tester/covoar/SymbolSet.cpp b/tester/

[PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-25 Thread Cillian O'Donnell
Add ability to organize symbol sets of libraries in symbol_set.cfg and then read them with covoar (Krzysztof Miesowicz)) Also the symbols are now loaded in from ELF data rather than relying on nm.(Cillian O'Donnell) Co-author:"Krzysztof Miesowicz " --- tester/covoar/SymbolSet.cpp | 153