Re: [PATCH 1/2] bsps/aarch64/raspberrypi: Refactor code base

2023-08-07 Thread Kinsey Moore
That sounds fine to me. Thanks, Kinsey On Mon, Aug 7, 2023 at 10:53 AM Utkarsh Verma wrote: > Hi Kinsey, > > Thanks for the suggestions. I'll break it up into several commits as > you suggested. Shall I break it down as follows? > > - Build spec changes > - Formatting changes > - Macro renaming

Re: [PATCH 1/2] bsps/aarch64/raspberrypi: Refactor code base

2023-08-07 Thread Utkarsh Verma
Hi Kinsey, Thanks for the suggestions. I'll break it up into several commits as you suggested. Shall I break it down as follows? - Build spec changes - Formatting changes - Macro renamings Regards, Utkarsh On Mon, Aug 7, 2023 at 8:49 PM Kinsey Moore wrote: > I would say that the content here

Re: [PATCH 1/2] bsps/aarch64/raspberrypi: Refactor code base

2023-08-07 Thread Kinsey Moore
I would say that the content here is easily worth several patches. You've got header rearrangements and other formatting changes mixed in with macro renamings, build system changes, and other things. One comment below on the .gitignore. You've also got inconsistencies in usage of (C) vs (c). On Su

[PATCH 1/2] bsps/aarch64/raspberrypi: Refactor code base

2023-08-06 Thread Utkarsh Verma
From: Utkarsh Verma Refactor the code base for better organization to facilitate future patches. --- .gitignore| 4 + bsps/aarch64/raspberrypi/console/console.c| 42 +- bsps/aarch64/raspberrypi/include/bsp.h| 33 +- .../aarch64/raspberrypi/incl