Re: [PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-20 Thread Patrick Gauvin
Thank you, that does simplify things quite a bit. -Patrick On Thu, Apr 20, 2017 at 5:50 PM, Chris Johns wrote: > On 21/04/2017 07:22, Patrick Gauvin wrote: > >> >> I so not like the reset value being written to like this. I know you >> need to set the lower 4 bits to 1 when loading the

Re: [PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-20 Thread Chris Johns
On 21/04/2017 07:22, Patrick Gauvin wrote: I so not like the reset value being written to like this. I know you need to set the lower 4 bits to 1 when loading the fabric via PCAP but there are 4 independent resets and I have applications that have individual control once loaded.

Re: [PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-20 Thread Patrick Gauvin
Chris, >> + >> +#define ZYNQ_SLCR_BASE_ADDR ( 0xF800 ) >> +/* NOTE: QEMU gives a value of 0 for the pss_idcode. */ >> +#define ZYNQ_SLCR_PSS_IDCODE_OFF ( 0x530 ) >> +#define ZYNQ_SLCR_PSS_IDCODE_DEVICE_GET( reg ) BSP_FLD32GET( reg, 12, >> 16 ) >> +#define ZYNQ_SLCR_LVL_SHFTR_EN_OFF ( 0x900 )

Re: [PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-19 Thread Chris Johns
Thanks for submitting this driver. My comments are below. Chris On 20/04/2017 13:06, Patrick Gauvin wrote: --- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 ++ .../arm/xilinx-zynq/include/zynq-slcr-regs.h | 84 .../lib/libbsp/arm/xilinx-zynq/include/zynq-s

[PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-19 Thread Patrick Gauvin
--- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 ++ .../arm/xilinx-zynq/include/zynq-slcr-regs.h | 84 .../lib/libbsp/arm/xilinx-zynq/include/zynq-slcr.h | 70 + c/src/lib/libbsp/arm/xilinx-zynq/preinstall.am | 8 ++ c/src/lib/libbsp/arm/

[PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-19 Thread Patrick Gauvin
--- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 ++ .../arm/xilinx-zynq/include/zynq-slcr-regs.h | 84 .../lib/libbsp/arm/xilinx-zynq/include/zynq-slcr.h | 70 + c/src/lib/libbsp/arm/xilinx-zynq/preinstall.am | 8 ++ c/src/lib/libbsp/arm/