Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-16 Thread Amar Takhar
On 2020-03-16 09:40 +0100, Sebastian Huber wrote: > > I work currently on a draft for the Python development guidelines for the > engineering manual. I hope to have something ready for review in the next > days. > > Documenting the tests with with pydoc strings in general would be overkill > fr

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-16 Thread Sebastian Huber
On 16/03/2020 00:58, Amar Takhar wrote: On 2020-03-14 11:12 +1100, Chris Johns wrote: I would like to hear what Sebastian is considering for the ESA work. I think we should follow what will be done there and ends up in the engineering manual. If this is in regard to pytests that are being done

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-14 11:12 +1100, Chris Johns wrote: > > I would like to hear what Sebastian is considering for the ESA work. I think > we > should follow what will be done there and ends up in the engineering manual. If this is in regard to pytests that are being done for ESA work I agree I would lik

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-13 Thread Amar Takhar
On 2020-03-14 11:12 +1100, Chris Johns wrote: > > I would like to hear what Sebastian is considering for the ESA work. I think > we > should follow what will be done there and ends up in the engineering manual. I'm talking about pytest specifically. The documentation is for the unit tests not

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-13 Thread Chris Johns
On 14/3/20 10:48 am, Amar Takhar wrote: > On 2020-03-13 17:28 -0600, Gedare Bloom wrote: > >> pydoc? > > I've never added pydoc to this as it's a generic test class the documentation > is > in the test names eg, test_.*(). You can add a string above to add more > verbosity if required but any

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-13 Thread Amar Takhar
On 2020-03-13 17:28 -0600, Gedare Bloom wrote: > License/file header? Oh, right I forgot about that, thank you. > pydoc? I've never added pydoc to this as it's a generic test class the documentation is in the test names eg, test_.*(). You can add a string above to add more verbosity if req

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-13 Thread Gedare Bloom
On Fri, Mar 13, 2020 at 3:35 PM Amar Takhar wrote: > > This converts three files: > > error.py: > - Check for exceptions and error messages > > path.py: > - Test params and setting module variables > > macros.py: > - Test class with setup and shared module access > > This should cover the bu

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-13 Thread Amar Takhar
I'm aware of the typo in the internal test I've fixed this already. Amar. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH 1/2] Start converting tests to pytest.

2020-03-13 Thread Amar Takhar
This converts three files: error.py: - Check for exceptions and error messages path.py: - Test params and setting module variables macros.py: - Test class with setup and shared module access This should cover the bulk of what is required to convert the rest to pytest. Also removes the ol