Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

2015-06-25 Thread André Marques
On 24-06-2015 15:03, Gedare Bloom wrote: On Tue, Jun 23, 2015 at 6:44 PM, André Marques wrote: On 23-06-2015 17:16, Gedare Bloom wrote: + uint32_t bank; + int handled_count; + int rv; + + gpio = (gpio_pin*) arg; + + bank = gpio->bank_number; Validate args for errors. These tasks are

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

2015-06-24 Thread Gedare Bloom
On Tue, Jun 23, 2015 at 6:44 PM, André Marques wrote: > On 23-06-2015 17:16, Gedare Bloom wrote: > + uint32_t bank; > + int handled_count; > + int rv; > + > + gpio = (gpio_pin*) arg; > + > + bank = gpio->bank_number; Validate args for errors. >>

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

2015-06-23 Thread André Marques
On 23-06-2015 17:16, Gedare Bloom wrote: + uint32_t bank; + int handled_count; + int rv; + + gpio = (gpio_pin*) arg; + + bank = gpio->bank_number; Validate args for errors. These tasks are only created by the rtems_gpio_enable_interrupt() function, and all parameters are validated befor

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

2015-06-23 Thread Gedare Bloom
>> >> >>> + uint32_t bank; >>> + int handled_count; >>> + int rv; >>> + >>> + gpio = (gpio_pin*) arg; >>> + >>> + bank = gpio->bank_number; >> >> Validate args for errors. > > > These tasks are only created by the rtems_gpio_enable_interrupt() function, > and all parameters are validated befor

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

2015-06-22 Thread André Marques
Hello Gedare, first of all thanks for the review. Answers bellow. On 22-06-2015 16:05, Gedare Bloom wrote: ( On Mon, Jun 22, 2015 at 8:01 AM, Andre Marques wrote: --- c/src/lib/libbsp/Makefile.am |3 +- c/src/lib/libbsp/preinstall.am |4 + c/src/lib/libbsp/shar

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

2015-06-22 Thread Gedare Bloom
( On Mon, Jun 22, 2015 at 8:01 AM, Andre Marques wrote: > --- > c/src/lib/libbsp/Makefile.am |3 +- > c/src/lib/libbsp/preinstall.am |4 + > c/src/lib/libbsp/shared/gpio.c | 1083 > > c/src/lib/libbsp/shared/include/gpio.h | 6

[PATCH 1/2] RTEMS GPIO API definition and implementation.

2015-06-22 Thread Andre Marques
--- c/src/lib/libbsp/Makefile.am |3 +- c/src/lib/libbsp/preinstall.am |4 + c/src/lib/libbsp/shared/gpio.c | 1083 c/src/lib/libbsp/shared/include/gpio.h | 610 ++ 4 files changed, 1699 insertions(+), 1 deletion(-