Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-06 Thread Gedare Bloom
map might be fine. some other possibilities: index, offset, field. I just noticed though that this proposed callout seems somewhat awkward since it will return a void* pointing to something not a node, and the return likely goes to something expecting an RBTree_Node*? Why not leave it to the calle

Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-06 Thread Gedare Bloom
On Tue, Apr 5, 2016 at 11:35 AM, Sebastian Huber wrote: > > - Gedare Bloom schrieb: >> I don't understand the name "adjust"? I think of adjusting as >> something that would cause a change or modify, which is not the case >> here. I don't have any great replacement, but I guess I might suggest

Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Gedare Bloom
I don't understand the name "adjust"? I think of adjusting as something that would cause a change or modify, which is not the case here. I don't have any great replacement, but I guess I might suggest "dereference"? On Tue, Apr 5, 2016 at 9:09 AM, Sebastian Huber wrote: > --- > cpukit/posix/incl

Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Sebastian Huber
Maybe "map"? - Gedare Bloom schrieb: > On Tue, Apr 5, 2016 at 11:35 AM, Sebastian Huber > wrote: > > > > - Gedare Bloom schrieb: > >> I don't understand the name "adjust"? I think of adjusting as > >> something that would cause a change or modify, which is not the case > >> here. I don'

Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Sebastian Huber
- Gedare Bloom schrieb: > I don't understand the name "adjust"? I think of adjusting as > something that would cause a change or modify, which is not the case > here. I don't have any great replacement, but I guess I might suggest > "dereference"? You may adjust the pointer value, e.g. node

[PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Sebastian Huber
--- cpukit/posix/include/rtems/posix/keyimpl.h | 14 ++ cpukit/posix/src/keygetspecific.c | 15 ++- cpukit/posix/src/keysetspecific.c | 29 + cpukit/score/include/rtems/score/rbtree.h | 12 4 files changed, 37 inse