Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-11 Thread Chris Johns
On 11/04/2016 23:37, Joel Sherrill wrote: Ultimately we have to rely on something to do the right thing. The design issue is a struct and code in the score is dependent on something in a header in another file in another part of RTEMS, ie confdefs.h to actually work as expected. It is easy t

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-11 Thread Joel Sherrill
On Mon, Apr 11, 2016 at 8:17 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > - Chris Johns schrieb: > > On 8/04/2016 7:34 PM, Sebastian Huber wrote: > > > On 08/04/16 11:22, Chris Johns wrote: > > >>> I don't think its feasible to avoid . Its now the > only > > >>> way to

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-11 Thread Sebastian Huber
- Chris Johns schrieb: > On 8/04/2016 7:34 PM, Sebastian Huber wrote: > > On 08/04/16 11:22, Chris Johns wrote: > >>> I don't think its feasible to avoid . Its now the only > >>> way to create a configuration. > >>> > >> > >> Sorry, but I do not like confdefs getting these values in this way.

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-08 Thread Chris Johns
On 8/04/2016 7:34 PM, Sebastian Huber wrote: On 08/04/16 11:22, Chris Johns wrote: I don't think its feasible to avoid . Its now the only way to create a configuration. Sorry, but I do not like confdefs getting these values in this way. This is not a great long term solution. Easy to add very

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-08 Thread Sebastian Huber
On 08/04/16 11:22, Chris Johns wrote: I don't think its feasible to avoid . Its now the only way to create a configuration. Sorry, but I do not like confdefs getting these values in this way. This is not a great long term solution. Easy to add very hard to remove. Maybe you need make s

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-08 Thread Chris Johns
On 8/04/2016 6:30 PM, Sebastian Huber wrote: The _Assert() is only active in case you use RTEMS_DEBUG. Then that is no good. I don't think its feasible to avoid . Its now the only way to create a configuration. Sorry, but I do not like confdefs getting these values in this way. This is

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-08 Thread Sebastian Huber
On 08/04/16 10:07, Chris Johns wrote: On 8/04/2016 5:35 PM, Sebastian Huber wrote: On 08/04/16 09:06, Chris Johns wrote: I assume the microsecond, nanosecond and tick per sec values all need to agree. Does anything check this is the case and raise a fatal error if they do not? Currently no

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-08 Thread Chris Johns
On 8/04/2016 5:35 PM, Sebastian Huber wrote: On 08/04/16 09:06, Chris Johns wrote: I assume the microsecond, nanosecond and tick per sec values all need to agree. Does anything check this is the case and raise a fatal error if they do not? Currently nobody checks this. Should we check this vi

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-08 Thread Sebastian Huber
On 08/04/16 09:06, Chris Johns wrote: On 8/04/2016 4:49 PM, Sebastian Huber wrote: This avoids the calculation of this value at run-time, similar to rtems_configuration_get_nanoseconds_per_tick(). Delete TOD_TICKS_PER_SECOND and replace it with rtems_configuration_get_ticks_per_second(). ---

Re: [PATCH 02/12] score: Add ticks per second to configuration

2016-04-08 Thread Chris Johns
On 8/04/2016 4:49 PM, Sebastian Huber wrote: This avoids the calculation of this value at run-time, similar to rtems_configuration_get_nanoseconds_per_tick(). Delete TOD_TICKS_PER_SECOND and replace it with rtems_configuration_get_ticks_per_second(). --- a/cpukit/sapi/include/confdefs.h +++ b/cp

[PATCH 02/12] score: Add ticks per second to configuration

2016-04-07 Thread Sebastian Huber
This avoids the calculation of this value at run-time, similar to rtems_configuration_get_nanoseconds_per_tick(). Delete TOD_TICKS_PER_SECOND and replace it with rtems_configuration_get_ticks_per_second(). --- cpukit/posix/src/alarm.c | 3 ++- cpukit/sapi/include/confdefs.h