Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-10 Thread Chris Johns
On 9/3/21 5:28 pm, Gedare Bloom wrote: > On Mon, Mar 8, 2021 at 11:04 PM Sebastian Huber > wrote: >> >> On 09/03/2021 06:47, Gedare Bloom wrote: >> >> I would just use a comment which is understood by GCC, clang, and >> Coverity. What does Linux use? >> > That's fine, if there i

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Gedare Bloom
On Mon, Mar 8, 2021 at 11:04 PM Sebastian Huber wrote: > > On 09/03/2021 06:47, Gedare Bloom wrote: > > I would just use a comment which is understood by GCC, clang, and > Coverity. What does Linux use? > > >>> That's fine, if there is a de facto standard to use, we can go for it. >

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Sebastian Huber
On 09/03/2021 06:47, Gedare Bloom wrote: I would just use a comment which is understood by GCC, clang, and Coverity. What does Linux use? That's fine, if there is a de facto standard to use, we can go for it. Looking at the option documentation gcc supports a lot of different possible ways an

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Gedare Bloom
On Mon, Mar 8, 2021 at 7:21 PM Chris Johns wrote: > > On 6/3/21 6:04 am, Gedare Bloom wrote: > > On Fri, Mar 5, 2021 at 11:48 AM Sebastian Huber > > wrote: > >> > >> On 05/03/2021 19:40, Joel Sherrill wrote: > >> > >>> On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber > >>> >>>

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-08 Thread Chris Johns
On 6/3/21 6:04 am, Gedare Bloom wrote: > On Fri, Mar 5, 2021 at 11:48 AM Sebastian Huber > wrote: >> >> On 05/03/2021 19:40, Joel Sherrill wrote: >> >>> On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber >>> >> > wrote: >>> >>> On 05/03/2021 16:27, Gedare

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-05 Thread Gedare Bloom
On Fri, Mar 5, 2021 at 11:48 AM Sebastian Huber wrote: > > On 05/03/2021 19:40, Joel Sherrill wrote: > > > On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber > > > > wrote: > > > > On 05/03/2021 16:27, Gedare Bloom wrote: > > > > > Should we add a mac

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-05 Thread Sebastian Huber
On 05/03/2021 19:40, Joel Sherrill wrote: On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber > wrote: On 05/03/2021 16:27, Gedare Bloom wrote: > Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we > can update them in fu

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-05 Thread Joel Sherrill
On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 05/03/2021 16:27, Gedare Bloom wrote: > > > Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we > > can update them in future if needed for other tools? > I would just pick a name whi

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-05 Thread Sebastian Huber
On 05/03/2021 16:27, Gedare Bloom wrote: Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we can update them in future if needed for other tools? I would just pick a name which is understood by GCC, clang, and Coverity. I guess other tools will understand this or why did you

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-05 Thread Gedare Bloom
Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we can update them in future if needed for other tools? Regardless of the addition of a macro these are fine, the grlib one came through separately I think. But I'd like to see a macro proposed. On Wed, Mar 3, 2021 at 2:26 PM Rya

[PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-03 Thread Ryan Long
Hi, To fix these Coverity issues, I just needed to add a comment to tell Coverity to ignore the error. I did this using the same method as shown in this article https://www.synopsys.com/blogs/software-security/gimme-a-break/. Thanks, Ryan Ryan Long (3): grtc.c: Fix four Missing break in switch