Re: [PATCH] testsuite: Use printk for all test output where possible.

2017-10-19 Thread Chris Johns
On 19/10/2017 21:52, Sebastian Huber wrote: > On 19/10/17 09:29, Chris Johns wrote: >> On 19/10/17 5:01 pm, Sebastian Huber wrote: >>> On 19/10/17 07:45, Chris Johns wrote: - Remove the printf support leaving the direct printk support configured with TESTS_USE_PRINTK and all other out

Re: [PATCH] testsuite: Use printk for all test output where possible.

2017-10-19 Thread Sebastian Huber
On 19/10/17 09:29, Chris Johns wrote: On 19/10/17 5:01 pm, Sebastian Huber wrote: On 19/10/17 07:45, Chris Johns wrote: - Remove the printf support leaving the direct printk support configured    with TESTS_USE_PRINTK and all other output goes via a buffered vsniprintf    call to printk. Wha

Re: [PATCH] testsuite: Use printk for all test output where possible.

2017-10-19 Thread Chris Johns
On 19/10/17 5:22 pm, Chris Johns wrote: > On 19/10/17 4:59 pm, Sebastian Huber wrote: >> On 19/10/17 07:45, Chris Johns wrote: >>> - Control the test's single init for functions and global data with >>>    TEST_INIT and not CONFIGURE_INIT. They are now separate. >> >> Could we move the implementati

Re: [PATCH] testsuite: Use printk for all test output where possible.

2017-10-19 Thread Chris Johns
On 19/10/17 5:01 pm, Sebastian Huber wrote: > On 19/10/17 07:45, Chris Johns wrote: >> - Remove the printf support leaving the direct printk support configured >>    with TESTS_USE_PRINTK and all other output goes via a buffered vsniprintf >>    call to printk. > > What is the benefit of this buff

Re: [PATCH] testsuite: Use printk for all test output where possible.

2017-10-18 Thread Chris Johns
On 19/10/17 4:59 pm, Sebastian Huber wrote: > On 19/10/17 07:45, Chris Johns wrote: >> - Control the test's single init for functions and global data with >>    TEST_INIT and not CONFIGURE_INIT. They are now separate. > > Could we move the implementation of this stuff to cpukit/libmisc/testsupport

Re: [PATCH] testsuite: Use printk for all test output where possible.

2017-10-18 Thread Sebastian Huber
On 19/10/17 07:45, Chris Johns wrote: - Remove the printf support leaving the direct printk support configured with TESTS_USE_PRINTK and all other output goes via a buffered vsniprintf call to printk. What is the benefit of this buffered IO compared to printk? -- Sebastian Huber, embedde

Re: [PATCH] testsuite: Use printk for all test output where possible.

2017-10-18 Thread Sebastian Huber
On 19/10/17 07:45, Chris Johns wrote: - Control the test's single init for functions and global data with TEST_INIT and not CONFIGURE_INIT. They are now separate. Could we move the implementation of this stuff to cpukit/libmisc/testsupport? This would avoid the need for this TEST_INIT defi