Re: [PATCH] score: Canonicalize _CPU_Fatal_halt()

2021-07-28 Thread Joel Sherrill
On Wed, Jul 28, 2021 at 8:45 AM Sebastian Huber wrote: > > On 28/07/2021 15:42, Joel Sherrill wrote: > > In reviewing horizontally, I see one implementation that calls > > printk(). Is that necessary and of value now? > > I was a bit unsure about this one. The default implementation is: > > void _

Re: [PATCH] score: Canonicalize _CPU_Fatal_halt()

2021-07-28 Thread Sebastian Huber
On 28/07/2021 15:42, Joel Sherrill wrote: In reviewing horizontally, I see one implementation that calls printk(). Is that necessary and of value now? I was a bit unsure about this one. The default implementation is: void _CPU_Fatal_halt( uint32_t source, CPU_Uint32ptr error ) { ISR_Level le

Re: [PATCH] score: Canonicalize _CPU_Fatal_halt()

2021-07-28 Thread Joel Sherrill
This looks pretty mechanical and OK. In reviewing horizontally, I see one implementation that calls printk(). Is that necessary and of value now? Also do we have a preference for while forever loops? I see at least two ways they are implemented. This change appears to faithfully move inline code

[PATCH] score: Canonicalize _CPU_Fatal_halt()

2021-07-28 Thread Sebastian Huber
Move _CPU_Fatal_halt() declaration to and make sure it is a proper declaration of a function which does not return. Fix the type of the error code. If necessary, add the implementation to cpu.c. Implementing _CPU_Fatal_halt() makes it possible to wrap this function for example to fully test _Te