Re: [PATCH] rtems-test-check: Make exclude work again.

2017-01-17 Thread Joel Sherrill
On Tue, Jan 17, 2017 at 9:34 AM, Stavros Passas wrote: > Hi Joel, > > Yesterday, with the creation of the ticket about the issue, ( > https://devel.rtems.org/ticket/2867) > I also uploaded the patch that was fixing it -- after Chris's suggestion > over email. > > The patch was created with my ful

Re: [PATCH] rtems-test-check: Make exclude work again.

2017-01-17 Thread Stavros Passas
Hi Joel, Yesterday, with the creation of the ticket about the issue, ( https://devel.rtems.org/ticket/2867) I also uploaded the patch that was fixing it -- after Chris's suggestion over email. The patch was created with my full credentials, so you can take them from here: https://devel.rtems.org/

Re: [PATCH] rtems-test-check: Make exclude work again.

2017-01-17 Thread Joel Sherrill
On Mon, Jan 16, 2017 at 5:12 PM, Chris Johns wrote: > This change looks wrong. Moving test loop out of the if testdata block > means variables in the test loop are not defined. I consider it a script > bug to assume it is ok to reference a variable that is not declared > because it is ambiguous i

Re: [PATCH] rtems-test-check: Make exclude work again.

2017-01-16 Thread Chris Johns
This change looks wrong. Moving test loop out of the if testdata block means variables in the test loop are not defined. I consider it a script bug to assume it is ok to reference a variable that is not declared because it is ambiguous if this intended behavior or a bug. Starvos sent me this chang

[PATCH] rtems-test-check: Make exclude work again.

2017-01-16 Thread Joel Sherrill
closes #2867. --- tools/build/rtems-test-check | 90 ++-- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/tools/build/rtems-test-check b/tools/build/rtems-test-check index e02f8e9..e8acde0 100755 --- a/tools/build/rtems-test-check +++ b/tools