Re: [PATCH] rtems: Make rtems_version_control_key() safer

2019-09-10 Thread Peter Dufault
> On Sep 9, 2019, at 22:00 , Chris Johns wrote: > > I would prefer we provide an interface to say the version control key has been > set rather than exposing how we manage it. I think the change to not return > NULL > is the correct one. What about adding .. > > bool rtems_version_control_ke

Re: [PATCH] rtems: Make rtems_version_control_key() safer

2019-09-09 Thread Chris Johns
On 6/9/19 10:34 pm, Sebastian Huber wrote: > Return the empty string instead of a NULL pointer if no version key is > available. > --- > cpukit/include/rtems/version.h | 9 ++--- > cpukit/sapi/src/version.c | 2 +- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/cpuki

[PATCH] rtems: Make rtems_version_control_key() safer

2019-09-06 Thread Sebastian Huber
Return the empty string instead of a NULL pointer if no version key is available. --- cpukit/include/rtems/version.h | 9 ++--- cpukit/sapi/src/version.c | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/cpukit/include/rtems/version.h b/cpukit/include/rtems/version.h