Re: [PATCH] rsb: Fix Spike build

2020-04-08 Thread Gedare Bloom
Is the dtc version in spike hardcoded? If so would you update it to use the dtc redirect instead? On Wed, Apr 8, 2020, 4:18 AM Hesham Almatary wrote: > Joel and Christian, > > Thanks for your review. > > Spike bset was already using dtc-1.4.1. I submitted patches to bump > dtc.bset itself. Are t

Re: [PATCH] rsb: Fix Spike build

2020-04-08 Thread Hesham Almatary
Joel and Christian, Thanks for your review. Spike bset was already using dtc-1.4.1. I submitted patches to bump dtc.bset itself. Are there any other patches I should apply? Cheers, Hesham On Wed, 8 Apr 2020 at 10:18, Christian Mauderer wrote: > > Hello Hesham and Joel, > > On 07/04/2020 16:01,

Re: [PATCH] rsb: Fix Spike build

2020-04-08 Thread Christian Mauderer
Hello Hesham and Joel, On 07/04/2020 16:01, Joel Sherrill wrote: > Please apply your Christian's and your patch. I haven't created a patch for 1.4 yet. But it's quite straightforward. So maybe just create one instead of applying mine. Best regards Christian > > Also bump the dtc base package

Re: [PATCH] rsb: Fix Spike build

2020-04-07 Thread Joel Sherrill
Please apply your Christian's and your patch. Also bump the dtc base package version number. I thought we settled on 1.4. --joel On Tue, Apr 7, 2020 at 3:56 AM Hesham Almatary wrote: > * There is no all$ target in Spike > * There is no longer --with-fesvr flag since fesvr is source-inlined >

[PATCH] rsb: Fix Spike build

2020-04-07 Thread Hesham Almatary
* There is no all$ target in Spike * There is no longer --with-fesvr flag since fesvr is source-inlined by default --- source-builder/config/spike-1-1.cfg | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/source-builder/config/spike-1-1.cfg b/source-builder/config/spike-1-1