Re: [PATCH] riscv: Mark htif_console_handler in htif.h as extern

2020-05-21 Thread Gedare Bloom
On Thu, May 21, 2020 at 6:36 PM Hesham Almatary wrote: > > On Mon, 18 May 2020 at 06:10, Gedare Bloom wrote: > > > > you can push this one. I don't know if there are others? > > Thanks! Yeah, just one more here [1] but it's not vital/used yet. > If it's dead code, hold off until 6, thanks > [1]

Re: [PATCH] riscv: Mark htif_console_handler in htif.h as extern

2020-05-21 Thread Hesham Almatary
On Mon, 18 May 2020 at 06:10, Gedare Bloom wrote: > > you can push this one. I don't know if there are others? Thanks! Yeah, just one more here [1] but it's not vital/used yet. [1] https://lists.rtems.org/pipermail/devel/2020-May/059772.html > > On Sun, May 17, 2020 at 7:06 PM Hesham Almatary >

Re: [PATCH] riscv: Mark htif_console_handler in htif.h as extern

2020-05-17 Thread Gedare Bloom
you can push this one. I don't know if there are others? On Sun, May 17, 2020 at 7:06 PM Hesham Almatary wrote: > > > > On Sun, 17 May 2020 at 23:45, Joel Sherrill wrote: >> >> I hope you have committed these by now. :) > > Not yet, was waiting for approval. Shall I wait for the release first? >

Re: [PATCH] riscv: Mark htif_console_handler in htif.h as extern

2020-05-17 Thread Hesham Almatary
On Sun, 17 May 2020 at 23:45, Joel Sherrill wrote: > I hope you have committed these by now. :) > Not yet, was waiting for approval. Shall I wait for the release first? > > On Thu, May 7, 2020 at 3:14 PM wrote: > >> From: Hesham Almatary >> >> It is defined in htif.c >> --- >> bsps/riscv/risc

Re: [PATCH] riscv: Mark htif_console_handler in htif.h as extern

2020-05-17 Thread Joel Sherrill
I hope you have committed these by now. :) On Thu, May 7, 2020 at 3:14 PM wrote: > From: Hesham Almatary > > It is defined in htif.c > --- > bsps/riscv/riscv/include/dev/serial/htif.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bsps/riscv/riscv/include/dev/serial/h

[PATCH] riscv: Mark htif_console_handler in htif.h as extern

2020-05-07 Thread heshamelmatary
From: Hesham Almatary It is defined in htif.c --- bsps/riscv/riscv/include/dev/serial/htif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/riscv/riscv/include/dev/serial/htif.h b/bsps/riscv/riscv/include/dev/serial/htif.h index b0d83652b..4b16d8746 100644 --- a/bsps/r