Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-09 Thread Sebastian Huber
On 10/08/18 01:44, Chris Johns wrote: On 07/08/2018 15:33, Chris Johns wrote: I will ping Amar tomorrow. I do not touch the Trac install. Amar has installed the clone tool (Thank you). There is now a Clone button on the tickets besides the Reply and Delete buttons. Thanks, this makes it easi

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-09 Thread Chris Johns
On 07/08/2018 15:33, Chris Johns wrote: > > I will ping Amar tomorrow. I do not touch the Trac install. > Amar has installed the clone tool (Thank you). There is now a Clone button on the tickets besides the Reply and Delete buttons. Chris ___ devel m

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-06 Thread Chris Johns
On 07/08/2018 15:30, Sebastian Huber wrote: > > Since multiple milestones per ticket are unrealistic in Trac and what you > wrote > above I think this plug-in is still useful: > > https://trac.edgewall.org/wiki/TicketClone > > The basic work flow is: > > 1. Add a ticket for the master. > > 2.

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-06 Thread Sebastian Huber
On 07/08/18 03:18, Chris Johns wrote: On 06/08/2018 23:21, Sebastian Huber wrote: On 06/08/18 15:03, Joel Sherrill wrote: On Mon, Aug 6, 2018, 3:01 AM Sebastian Huber mailto:sebastian.hu...@embedded-brains.de>> wrote:     On 06/08/18 09:47, Chris Johns wrote:     > On 06/08/2018 16:13, Sebas

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-06 Thread Chris Johns
On 06/08/2018 23:21, Sebastian Huber wrote: > On 06/08/18 15:03, Joel Sherrill wrote: >> On Mon, Aug 6, 2018, 3:01 AM Sebastian Huber >> > > wrote: >> >>     On 06/08/18 09:47, Chris Johns wrote: >>     > On 06/08/2018 16:13, Sebastian Huber wrote: >>    

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-06 Thread Sebastian Huber
On 06/08/18 15:03, Joel Sherrill wrote: On Mon, Aug 6, 2018, 3:01 AM Sebastian Huber > wrote: On 06/08/18 09:47, Chris Johns wrote: > On 06/08/2018 16:13, Sebastian Huber wrote: >> this needs a back port to 4.11 and 4.10. >> > I

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-06 Thread Joel Sherrill
On Mon, Aug 6, 2018, 3:01 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 06/08/18 09:47, Chris Johns wrote: > > On 06/08/2018 16:13, Sebastian Huber wrote: > >> this needs a back port to 4.11 and 4.10. > >> > > I saw the ticket for 4.10 and assumed the patch was for 4.10. We

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-06 Thread Sebastian Huber
On 06/08/18 09:47, Chris Johns wrote: On 06/08/2018 16:13, Sebastian Huber wrote: this needs a back port to 4.11 and 4.10. I saw the ticket for 4.10 and assumed the patch was for 4.10. We separate tickets for each branch. This makes the ticket handling a bit more complicated. Why is this ne

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-06 Thread Chris Johns
On 06/08/2018 16:13, Sebastian Huber wrote: > > this needs a back port to 4.11 and 4.10. > I saw the ticket for 4.10 and assumed the patch was for 4.10. We separate tickets for each branch. Are you able to handle this or should I put it on the list? Chris __

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-05 Thread Sebastian Huber
Hello Chris, this needs a back port to 4.11 and 4.10. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request.

[PATCH] rfs: Remove erroneous call of rtems_disk_release()

2018-08-05 Thread Sebastian Huber
The function rtems_rfs_buffer_sync() erroneously calls rtems_disk_release(). This screws up the reference counting of the disk. Update #3484. --- cpukit/libfs/src/rfs/rtems-rfs-buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-buffer.c b/cpukit/libfs/src/