Re: [PATCH] removed unneccesary assigning to rc triggering unused value error in coverity

2020-02-27 Thread Gedare Bloom
On Thu, Feb 27, 2020 at 9:30 AM Joel Sherrill wrote: > > > > On Thu, Feb 27, 2020 at 9:48 AM Gedare Bloom wrote: >> >> Hi Suyash, >> >> I have a few comments for you. >> >> First, the commit message should follow the guidance at >> https://docs.rtems.org/branches/master/eng/vc-users.html#creatin

Re: [PATCH] removed unneccesary assigning to rc triggering unused value error in coverity

2020-02-27 Thread Joel Sherrill
On Thu, Feb 27, 2020 at 9:48 AM Gedare Bloom wrote: > Hi Suyash, > > I have a few comments for you. > > First, the commit message should follow the guidance at > https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch > and follow through the link about Commit Messages. We like

Re: [PATCH] removed unneccesary assigning to rc triggering unused value error in coverity

2020-02-27 Thread suyash singh
Okay sorry I missed out on the coding standards docs. yes code blocks edited without telling I will change its settings On Thu, Feb 27, 2020 at 9:18 PM Gedare Bloom wrote: > Hi Suyash, > > I have a few comments for you. > > First, the commit message should follow the guidance at > https://doc

Re: [PATCH] removed unneccesary assigning to rc triggering unused value error in coverity

2020-02-27 Thread Gedare Bloom
Hi Suyash, I have a few comments for you. First, the commit message should follow the guidance at https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch and follow through the link about Commit Messages. We like to have a short "tag" at the start of the commit to indicate the

[PATCH] removed unneccesary assigning to rc triggering unused value error in coverity

2020-02-27 Thread suyash singh
--- bsps/shared/dev/display/disp_hcms29xx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bsps/shared/dev/display/disp_hcms29xx.c b/bsps/shared/dev/display/disp_hcms29xx.c index 5730b36ea9..9d3e7220cf 100644 --- a/bsps/shared/dev/display/disp_hcms29xx.c +++ b/bsps/sh