Re: [PATCH] pc386: Add virtio network driver

2016-06-22 Thread Pavel Pisa
Hello Jin-Hyun, On Wednesday 22 of June 2016 04:10:00 Jinhyun wrote: > Thanks for the comments. > We are trying to either use the compiler memory barrier as you people > suggested or simply define the variables as volatile. We plan to repost the > revised patch in a week. > > Since new patch would

RE: [PATCH] pc386: Add virtio network driver

2016-06-21 Thread Jinhyun
at c/src/lib/ilbbsp/shared/. Hope this makes sense. Thanks, Jin-Hyun From: Joel Sherrill [mailto:j...@rtems.org] Sent: Tuesday, June 14, 2016 11:55 PM To: Gedare Bloom Cc: Jinhyun ; j...@konkuk.ac.kr; devel@rtems.org Subject: Re: [PATCH] pc386: Add virtio network driver Does the virtio.h file

Re: [PATCH] pc386: Add virtio network driver

2016-06-14 Thread Joel Sherrill
e mainline, it will be easier to continuously contribute > to > >> the virtio implementation from our side. > >> > >> Jin-Hyun > >> > >> -Original Message- > >> From: devel [mailto:devel-boun...@rtems.org] On Behalf Of Sebastian > Hube

Re: [PATCH] pc386: Add virtio network driver

2016-06-14 Thread Gedare Bloom
rom our side. > > Jin-Hyun > > -Original Message- > From: devel [mailto:devel-boun...@rtems.org] On Behalf Of Sebastian Huber > Sent: Wednesday, June 01, 2016 2:30 PM > To: Chris Johns ; devel@rtems.org > Subject: Re: [PATCH] pc386: Add virtio network driver > &

Re: [PATCH] pc386: Add virtio network driver

2016-06-14 Thread Gedare Bloom
gt; -----Original Message----- >> From: devel [mailto:devel-boun...@rtems.org] On Behalf Of Sebastian Huber >> Sent: Wednesday, June 01, 2016 2:30 PM >> To: Chris Johns ; devel@rtems.org >> Subject: Re: [PATCH] pc386: Add virtio network driver >> >> >> >>

RE: [PATCH] pc386: Add virtio network driver

2016-06-11 Thread Jinhyun
from our side. Jin-Hyun -Original Message- From: devel [mailto:devel-boun...@rtems.org] On Behalf Of Sebastian Huber Sent: Wednesday, June 01, 2016 2:30 PM To: Chris Johns ; devel@rtems.org Subject: Re: [PATCH] pc386: Add virtio network driver On 01/06/16 06:42, Chris Johns wrote

Re: [PATCH] pc386: Add virtio network driver

2016-05-31 Thread Sebastian Huber
On 01/06/16 06:42, Chris Johns wrote: The RTEMS driver infrastructure is not capable enough to deal with a plug-and-play architecture like x86. This does not make sense to me and I fail to see how it relates to the previous statement. The original classic API for RTEMS is based on a VME bus

Re: [PATCH] pc386: Add virtio network driver

2016-05-31 Thread Chris Johns
[ hijacked thread ] On 31/05/2016 21:05, Sebastian Huber wrote: the x86 architecture is not really interesting for me. So, I am not against a mainline integration. Great. However, I think we reached a dead end with the pc386 BSP. I do not agree, the BSP is alive and working ... ... yeap

Re: [PATCH] pc386: Add virtio network driver

2016-05-31 Thread Sebastian Huber
Hello Pavel, On 30/05/16 15:57, Pavel Pisa wrote: Hello Jin-Hyun and Sebastian, On Monday 30 of May 2016 15:06:40 Sebastian Huber wrote: >Wouldn't it make sense to use the libbsd for this network interface driver? my feeling is that from long run perspective is libBSD. But I think that virti

Re: [PATCH] pc386: Add virtio network driver

2016-05-30 Thread Chris Johns
On 30/05/2016 23:57, Pavel Pisa wrote: Hello Jin-Hyun and Sebastian, On Monday 30 of May 2016 15:06:40 Sebastian Huber wrote: Wouldn't it make sense to use the libbsd for this network interface driver? my feeling is that from long run perspective is libBSD. It would be nice to also see in l

Re: [PATCH] pc386: Add virtio network driver

2016-05-30 Thread Pavel Pisa
Hello Jin-Hyun and Sebastian, On Monday 30 of May 2016 15:06:40 Sebastian Huber wrote: > Wouldn't it make sense to use the libbsd for this network interface driver? my feeling is that from long run perspective is libBSD. But I think that virtio netwok included in basic RTEMS stack is very import

Re: [PATCH] pc386: Add virtio network driver

2016-05-30 Thread Sebastian Huber
Wouldn't it make sense to use the libbsd for this network interface driver? On 30/05/16 13:08, Jinhyun wrote: Hi, This is resubmitting of the virtio network driver. We got delayed again to write ifdef'ed version of the driver. We ifdef'ed RTEMS specific things of sources by RTEMS_VIRTIO_NET, an

RE: [PATCH] pc386: Add virtio network driver

2016-04-01 Thread Jinhyun
/README.txt. Let us know if this is OK. Thanks, Jin-Hyun From: Joel Sherrill [mailto:j...@rtems.org] Sent: Tuesday, March 29, 2016 11:41 PM To: Jinhyun Cc: rtems-de...@rtems.org ; j...@konkuk.ac.kr Subject: Re: [PATCH] pc386: Add virtio network driver Hi Thanks for the submission. My comments are

Re: [PATCH] pc386: Add virtio network driver

2016-03-29 Thread Joel Sherrill
Hi Thanks for the submission. My comments are going to be very general. + Can you document which version of the FreeBSD source files this is based up? Perhaps an svn revision/branch and a list of the exact files in their source tree? This has been a historical problem when trying to track future

[PATCH] pc386: Add virtio network driver

2016-03-29 Thread Jinhyun
diff --git a/c/src/lib/libbsp/i386/pc386/Makefile.am b/c/src/lib/libbsp/i386/pc386/Makefile.am index d9af7dd..da50c67 100644 --- a/c/src/lib/libbsp/i386/pc386/Makefile.am +++ b/c/src/lib/libbsp/i386/pc386/Makefile.am @@ -232,6 +232,19 @@ noinst_PROGRAMS += 3c509.rel 3c509_rel_LDFLAGS += -Wl,--unde