Re: [PATCH] linker_set.h: Add alignof implementation for when not C11 or C++11

2021-07-21 Thread Chris Johns
On 22/7/21 7:55 am, Joel Sherrill wrote: > On Wed, Jul 21, 2021, 4:31 PM Gedare Bloom > wrote: > > This seems alright to me. At least, it should get some complaints > quickly if it doesn't work :) > > The old version should have gotten complaints but didn't. Prob

Re: [PATCH] linker_set.h: Add alignof implementation for when not C11 or C++11

2021-07-21 Thread Joel Sherrill
On Wed, Jul 21, 2021, 4:31 PM Gedare Bloom wrote: > This seems alright to me. At least, it should get some complaints > quickly if it doesn't work :) > The old version should have gotten complaints but didn't. Probably indicates people are not being careful about specifying the language version

Re: [PATCH] linker_set.h: Add alignof implementation for when not C11 or C++11

2021-07-21 Thread Gedare Bloom
This seems alright to me. At least, it should get some complaints quickly if it doesn't work :) On Tue, Jul 20, 2021 at 3:04 PM Joel Sherrill wrote: > > The default implementation was completely broken. Use the GCC specific > __alignof__ if compiling for C99 or C++03. If not C++11, C11, or > GCC,

[PATCH] linker_set.h: Add alignof implementation for when not C11 or C++11

2021-07-20 Thread Joel Sherrill
The default implementation was completely broken. Use the GCC specific __alignof__ if compiling for C99 or C++03. If not C++11, C11, or GCC, then it is an error. --- freebsd/sys/sys/linker_set.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/freebsd/sys/sys/linker_set.h b/f