Re: [PATCH] libnetworking/rtems_dhcp.c: Fix improper hostname handling in DHCP request

2016-01-06 Thread Sebastian Huber
On 07/01/16 02:38, Aun-Ali Zaidi wrote: From: Tim Cussins DHCP requests add the hostname option in dhcp_request_req() - this is cool, except that the dhcp spec requires that this option has a length >= 1 char. Excerpt taken from RFC 2132: 3.14. Host Name Option This option specifi

[PATCH] libnetworking/rtems_dhcp.c: Fix improper hostname handling in DHCP request

2016-01-06 Thread Aun-Ali Zaidi
From: Tim Cussins DHCP requests add the hostname option in dhcp_request_req() - this is cool, except that the dhcp spec requires that this option has a length >= 1 char. Excerpt taken from RFC 2132: 3.14. Host Name Option This option specifies the name of the client. The name may or ma

Re: [PATCH] libnetworking/rtems_dhcp.c: Fix improper hostname handling in DHCP request

2016-01-04 Thread Sebastian Huber
On 04/01/16 12:55, Daniel Gutson wrote: > >> + >> + if ( (hostnamelen > 0) && (hostnamelen < 256) ) Avoid magic numbers. Should this be MAXHOSTNAMELEN, and in any case ot has been already limited before in the call to gethosname turning the check unnecessary? (Don't believe me, please

Re: [PATCH] libnetworking/rtems_dhcp.c: Fix improper hostname handling in DHCP request

2016-01-04 Thread Sebastian Huber
On 27/12/15 23:43, Aun-Ali Zaidi wrote: From: Tim Cussins DHCP requests add the hostname option in dhcp_request_req() - this is cool, except that the dhcp spec requires that this option has a length >= 1 char. ​ Excerpt taken from RFC 2132: 3.14. Host Name Option This option specif

[PATCH] libnetworking/rtems_dhcp.c: Fix improper hostname handling in DHCP request

2015-12-27 Thread Aun-Ali Zaidi
From: Tim Cussins DHCP requests add the hostname option in dhcp_request_req() - this is cool, except that the dhcp spec requires that this option has a length >= 1 char. ​ Excerpt taken from RFC 2132: 3.14. Host Name Option This option specifies the name of the client. The name may or m