Re: [PATCH] libc: Added sig2str/str2sig prototypes

2021-07-07 Thread Matthew Joyce
Dr. Joel, Thanks, I will make these changes and resubmit! Sincerely, Matt On Wed, Jul 7, 2021 at 3:57 PM Joel Sherrill wrote: > > On Wed, Jul 7, 2021 at 5:46 AM Matt Joyce wrote: > > > > Added definition of SIG2STR_MAX and function prototypes for sig2str > > and str2sig in sys/signal.h in ord

Re: [PATCH] libc: Added sig2str/str2sig prototypes

2021-07-07 Thread Joel Sherrill
On Wed, Jul 7, 2021 at 5:46 AM Matt Joyce wrote: > > Added definition of SIG2STR_MAX and function prototypes for sig2str > and str2sig in sys/signal.h in order to improve POSIX compliance. > --- > newlib/libc/include/sys/signal.h | 12 > 1 file changed, 12 insertions(+) > > diff --gi

[PATCH] libc: Added sig2str/str2sig prototypes

2021-07-07 Thread Matt Joyce
Added definition of SIG2STR_MAX and function prototypes for sig2str and str2sig in sys/signal.h in order to improve POSIX compliance. --- newlib/libc/include/sys/signal.h | 12 1 file changed, 12 insertions(+) diff --git a/newlib/libc/include/sys/signal.h b/newlib/libc/include/sys/si

Re: [PATCH] libc: Added sig2str/str2sig prototypes

2021-06-17 Thread Eshan Dhawan
> On 17-Jun-2021, at 1:14 PM, Matthew Joyce wrote: > > Hi Eshan, > > Thanks very much for this...It's really helpful! > > Question on workflow: > So for this example, I just apply the patch to RSB. Do I understand correctly > that we need to rebuild the tool chain each and every time I make a

Re: [PATCH] libc: Added sig2str/str2sig prototypes

2021-06-17 Thread Matthew Joyce
Hi Eshan, Thanks very much for this...It's really helpful! Question on workflow: So for this example, I just apply the patch to RSB. Do I understand correctly that we need to rebuild the tool chain each and every time I make any change? (Step 7 in Vaibhav's Blog) This didn't compile, apparently b

Re: [PATCH] libc: Added sig2str/str2sig prototypes

2021-06-16 Thread Eshan Dhawan
Hi Matt, Since you are making changes only to a header file you don’t need to run autoreconf. You can directly apply the patch to RSB and it should work You need to run autoreconf when u make changes in makefile That is when u add a .c file > On 17-Jun-2021, at 1:53 AM, Matt Joyce wrote: > >

[PATCH] libc: Added sig2str/str2sig prototypes

2021-06-16 Thread Matt Joyce
***As Requested: For Review Only. Does Not Compile*** Added definition of SIG2STR_MAX and function prototypes for sig2str and str2sig in sys/signal.h in order to improve POSIX compliance. --- newlib/libc/include/sys/signal.h | 12 1 file changed, 12 insertions(+) diff --git a/newlib