Re: [PATCH] fixed warning related to spstdc17

2023-11-10 Thread zack leung
ping On Tue, 31 Oct 2023 at 22:07, zack leung wrote: > Sorry either I lack knowledge in C or lack knowledge in working with > rtems. Do you mean if rtems smp is defined then we make sure that scheduler > context base type is defined? I don't quite understand why it would be > !defined? And the c

Re: [PATCH] fixed warning related to spstdc17

2023-10-31 Thread zack leung
Sorry either I lack knowledge in C or lack knowledge in working with rtems. Do you mean if rtems smp is defined then we make sure that scheduler context base type is defined? I don't quite understand why it would be !defined? And the changes you're referring to are not in the scheduler.h file which

Re: [PATCH] fixed warning related to spstdc17

2023-10-30 Thread Sebastian Huber
On 29.10.23 02:44, zack leung wrote: ./../../cpukit/include/rtems/score/schedulerpriority.h:87:21: error: field 'Base' has incomplete type    87 |   Scheduler_Context Base;       |                     ^~~~ ../../../cpukit/include/rtems/score/schedulersimple.h:89:21: error: field 'Base' has in

Re: [PATCH] fixed warning related to spstdc17

2023-10-30 Thread zack leung
./../../cpukit/include/rtems/score/schedulerpriority.h:87:21: error: field 'Base' has incomplete type 87 | Scheduler_Context Base; | ^~~~ ../../../cpukit/include/rtems/score/schedulersimple.h:89:21: error: field 'Base' has incomplete type 89 | Scheduler_Context B

Re: [PATCH] fixed warning related to spstdc17

2023-10-26 Thread Sebastian Huber
On 27.10.23 03:43, zack leung wrote: ping On Tue, 24 Oct 2023 at 22:17, zack leung > wrote: that didn't work but i'm thinking of defining a char array that is equal to the size of the processor lock and the isr lock? This is a bit complicated and

Re: [PATCH] fixed warning related to spstdc17

2023-10-26 Thread zack leung
ping On Tue, 24 Oct 2023 at 22:17, zack leung wrote: > that didn't work but i'm thinking of defining a char array that is equal > to the size of the processor lock and the isr lock? i figured that the > processor lock is 64 bits and isr lock is a one bit? > I'm confused on how to make an api d

Re: [PATCH] fixed warning related to spstdc17

2023-10-24 Thread zack leung
that didn't work but i'm thinking of defining a char array that is equal to the size of the processor lock and the isr lock? i figured that the processor lock is 64 bits and isr lock is a one bit? I'm confused on how to make an api define do you have a file i can look at? On Tue, 24 Oct 2023 a

Re: [PATCH] fixed warning related to spstdc17

2023-10-24 Thread Sebastian Huber
On 24.10.23 14:02, zack leung wrote: hi! sabestian did you mean the size of the structure? Yes, one option to get rid of the empty structures is to just provide typedefs, for example: #if defined(RTEMS_SMP) typedef struct Scheduler_Context { ... } Scheduler_Context; #else typedef struct S

Re: [PATCH] fixed warning related to spstdc17

2023-10-24 Thread zack leung
hi! sabestian did you mean the size of the structure? On Mon, 23 Oct 2023 at 10:20, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Zack, > > there is a bit more work to do to fix this warning. The warning fix > should not result in a size increase of the uniprocessor RTEMS >

Re: [PATCH] fixed warning related to spstdc17

2023-10-23 Thread Sebastian Huber
Hello Zack, there is a bit more work to do to fix this warning. The warning fix should not result in a size increase of the uniprocessor RTEMS configuration. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-

[PATCH] fixed warning related to spstdc17

2023-10-20 Thread zack liang
--- cpukit/include/rtems/score/isrlock.h | 1 + cpukit/include/rtems/score/scheduler.h | 1 + 2 files changed, 2 insertions(+) diff --git a/cpukit/include/rtems/score/isrlock.h b/cpukit/include/rtems/score/isrlock.h index 7586624f9d..612f17a34d 100644 --- a/cpukit/include/rtems/score/isrlock.h