Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-03 Thread Chris Johns
On 3/5/17 4:28 pm, Sebastian Huber wrote: > On 03/05/17 08:17, Chris Johns wrote: >> On 3/5/17 3:40 pm, Sebastian Huber wrote: >>> On 03/05/17 07:28, Chris Johns wrote: On 3/5/17 3:09 pm, Sebastian Huber wrote: > On 02/05/17 23:30, Chris Johns wrote: >> On 2/5/17 6:20 pm, Sebastian Hub

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
On 03/05/17 08:17, Chris Johns wrote: On 3/5/17 3:40 pm, Sebastian Huber wrote: On 03/05/17 07:28, Chris Johns wrote: On 3/5/17 3:09 pm, Sebastian Huber wrote: On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: [...] If you want to add this test please extract the

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Chris Johns
On 3/5/17 3:40 pm, Sebastian Huber wrote: > > On 03/05/17 07:28, Chris Johns wrote: >> On 3/5/17 3:09 pm, Sebastian Huber wrote: >>> On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: [...] > If you want to add this test please extract the version detai

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
On 03/05/17 07:28, Chris Johns wrote: On 3/5/17 3:09 pm, Sebastian Huber wrote: On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: [...] If you want to add this test please extract the version details from the build system Can we trust the build system? Give

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Chris Johns
On 3/5/17 3:09 pm, Sebastian Huber wrote: > On 02/05/17 23:30, Chris Johns wrote: >> On 2/5/17 6:20 pm, Sebastian Huber wrote: >>> + rtems_test_assert(__RTEMS_MAJOR__ == 4); >>> + rtems_test_assert(__RTEMS_MINOR__ == 11); >>> + rtems_test_assert(__RTEMS_REVISION__ == 99); >> Please do not push t

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: + rtems_test_assert(__RTEMS_MAJOR__ == 4); + rtems_test_assert(__RTEMS_MINOR__ == 11); + rtems_test_assert(__RTEMS_REVISION__ == 99); Please do not push this test like this, it breaks releases. The test will neve

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Chris Johns
On 2/5/17 6:20 pm, Sebastian Huber wrote: > + rtems_test_assert(__RTEMS_MAJOR__ == 4); > + rtems_test_assert(__RTEMS_MINOR__ == 11); > + rtems_test_assert(__RTEMS_REVISION__ == 99); Please do not push this test like this, it breaks releases. The test will never pass on a release. If you want t

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Daniel Hellstrom
Ok, good. I just was about to send my patch, but now I wont. Thanks! On 2017-05-02 10:20, Sebastian Huber wrote: --- cpukit/configure.ac| 2 +- testsuites/sptests/Makefile.am | 1 + testsuites/sptests/configure.ac| 1 + testsuit

[PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
--- cpukit/configure.ac| 2 +- testsuites/sptests/Makefile.am | 1 + testsuites/sptests/configure.ac| 1 + testsuites/sptests/spversion01/Makefile.am | 19 + testsuites/sptests/spversion01/init.c | 53 +