Re: [PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

On 5/6/21 8:11 am, Gedare Bloom wrote: > On Fri, Jun 4, 2021 at 1:17 PM Joel Sherrill wrote: >> >> On the surface, this looks OK to me. But I remember looking at this one >> and wondering if there was any cleanup required because of the various >> subroutine calls as you work down through this met

Re: [PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

On Fri, Jun 4, 2021 at 1:17 PM Joel Sherrill wrote: > > On the surface, this looks OK to me. But I remember looking at this one > and wondering if there was any cleanup required because of the various > subroutine calls as you work down through this method. > > Did you look into each of the subrou

Re: [PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

On the surface, this looks OK to me. But I remember looking at this one and wondering if there was any cleanup required because of the various subroutine calls as you work down through this method. Did you look into each of the subroutines called and make sure they didn't do further allocations?

[PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

See also CID 1439298 Closes #3570 --- cpukit/libblock/src/flashdisk.c | 16 1 file changed, 16 insertions(+) diff --git a/cpukit/libblock/src/flashdisk.c b/cpukit/libblock/src/flashdisk.c index 91f99e0d52..4de6ecd807 100644 --- a/cpukit/libblock/src/flashdisk.c +++ b/cpukit/libb