Re: [PATCH] cpukit/dosfs: Cast away ignored return

2024-01-04 Thread Kinsey Moore
The style in existing code displays both variants and the coding standards document isn't clear on the matter that I could find other than giving a demonstration of voiding an unused function argument that does have the space. Other commentary about spaces and parens deals with conditionals. On Th

Re: [PATCH] cpukit/dosfs: Cast away ignored return

2024-01-04 Thread Joel Sherrill
Don't we put a space after the (void)? On Thu, Jan 4, 2024 at 12:55 PM Kinsey Moore wrote: > An error is already being reported. Checking the return value of this > function is not useful. > --- > cpukit/libfs/src/dosfs/msdos_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

[PATCH] cpukit/dosfs: Cast away ignored return

2024-01-04 Thread Kinsey Moore
An error is already being reported. Checking the return value of this function is not useful. --- cpukit/libfs/src/dosfs/msdos_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libfs/src/dosfs/msdos_file.c b/cpukit/libfs/src/dosfs/msdos_file.c index d142968337..672