Re: [PATCH] covoar: Fix NULL check of wrong variable (CID #1399602)

2021-04-07 Thread Gedare Bloom
ok On Wed, Apr 7, 2021 at 11:47 AM Alex White wrote: > > CID 1399602: Dereference null return value in > Explanations::writeNotFound(). > > In Explanations::writeNotFound() there were two NULL checks of the > `fileName` variable where only one is needed. The second check has been > changed to a N

[PATCH] covoar: Fix NULL check of wrong variable (CID #1399602)

2021-04-07 Thread Alex White
CID 1399602: Dereference null return value in Explanations::writeNotFound(). In Explanations::writeNotFound() there were two NULL checks of the `fileName` variable where only one is needed. The second check has been changed to a NULL check of `notFoundFile` to match the original intent. Closes #4

Re: [PATCH] covoar: Fix NULL check of wrong variable

2021-04-07 Thread Joel Sherrill
Repeating what I added to the ticket: CID #1399602 is about a NULL reference in the same method which traces back to the incorrect variable being checked. Coverity didn't realize it was the wrong variable but did find something wrong that could lead to a NULL pointer dereference. Check me and

[PATCH] covoar: Fix NULL check of wrong variable

2021-04-07 Thread Alex White
In Explanations::writeNotFound() there were two NULL checks of the `fileName` variable where only one is needed. The second check has been changed to a NULL check of `notFoundFile` to match the original intent. Closes #4377 --- tester/covoar/Explanations.cc | 4 ++-- 1 file changed, 2 insertions(