Re: [PATCH] covoar: Fix DWARF reading

2021-03-14 Thread Chris Johns
On 14/3/21 8:43 am, Joel Sherrill wrote: > On Fri, Mar 12, 2021 at 5:47 PM Chris Johns > wrote: > > These are design question and not review issues > > On 12/3/21 5:33 am, Alex White wrote: > > +  // Create data based on target. > > +  TargetInfo = T

Re: [PATCH] covoar: Fix DWARF reading

2021-03-14 Thread Joel Sherrill
On Fri, Mar 12, 2021 at 5:47 PM Chris Johns wrote: > These are design question and not review issues > > On 12/3/21 5:33 am, Alex White wrote: > > + // Create data based on target. > > + TargetInfo = Target::TargetFactory( buildTarget ); > > Any pointers in this object given there is a cop

Re: [PATCH] covoar: Fix DWARF reading

2021-03-12 Thread Chris Johns
These are design question and not review issues On 12/3/21 5:33 am, Alex White wrote: > + // Create data based on target. > + TargetInfo = Target::TargetFactory( buildTarget ); Any pointers in this object given there is a copy operator at work here? > + // Create the set of desired symbo

[PATCH] covoar: Fix DWARF reading

2021-03-11 Thread Alex White
There were a couple of issues with the way the DWARF info was being read. The first issue was that it inefficiently included all symbols, even symbols that were not desired. The second issue is that it did not handle inline functions correctly. These have been fixed. --- tester/covoar/ExecutableIn