Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-09-20 Thread Chris Johns
On 21/9/20 3:02 pm, Sebastian Huber wrote: > > how do we want to proceed here? Without this patch the libbsd doesn't build. > OK to push. I will add a ticket for me to add a .pc file for libbsd. The remaining item was handling the user side of things. With a .pc file that contains the flags we

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-09-20 Thread Sebastian Huber
Hello, how do we want to proceed here? Without this patch the libbsd doesn't build. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Publ

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-13 Thread Sebastian Huber
On 14/07/2020 06:41, Chris Johns wrote: On 13/7/20 3:05 pm, Sebastian Huber wrote: On 13/07/2020 02:09, Chris Johns wrote: On 8/7/20 9:37 pm, Sebastian Huber wrote: On 08/07/2020 13:34, Chris Johns wrote: Are these flags needed for all BSPs? Yes, these flags are needed to build and use lib

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-13 Thread Chris Johns
On 13/7/20 3:05 pm, Sebastian Huber wrote: > On 13/07/2020 02:09, Chris Johns wrote: >> On 8/7/20 9:37 pm, Sebastian Huber wrote: >>> On 08/07/2020 13:34, Chris Johns wrote: >>> Are these flags needed for all BSPs? >>> Yes, these flags are needed to build and use libbsd. >> >> Why not define t

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-12 Thread Sebastian Huber
On 13/07/2020 02:09, Chris Johns wrote: On 8/7/20 9:37 pm, Sebastian Huber wrote: On 08/07/2020 13:34, Chris Johns wrote: Are these flags needed for all BSPs? Yes, these flags are needed to build and use libbsd. Why not define them for all BSPs In the new build system they are the defaul

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-12 Thread Chris Johns
On 8/7/20 9:37 pm, Sebastian Huber wrote: > On 08/07/2020 13:34, Chris Johns wrote: > >> Are these flags needed for all BSPs? > Yes, these flags are needed to build and use libbsd. Why not define them for all BSPs and for all applications? What is special about libbsd that it needs these flags o

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-08 Thread Sebastian Huber
On 08/07/2020 13:34, Chris Johns wrote: Are these flags needed for all BSPs? Yes, these flags are needed to build and use libbsd. If so why add to here ... https://git.rtems.org/rtems/tree/c/src/bsp.pc.in These are optimization flags. I thought the consensus was to export only ABI relevant f

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-08 Thread Chris Johns
Are these flags needed for all BSPs? If so why add to here ... https://git.rtems.org/rtems/tree/c/src/bsp.pc.in Chris On 8/7/20 7:17 pm, Sebastian Huber wrote: > --- > waf_libbsd.py | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/waf_libbsd.py b/waf_libbsd.py > index a817e574

[PATCH] build: Ensure mandatory compiler/linker flags

2020-07-08 Thread Sebastian Huber
--- waf_libbsd.py | 9 + 1 file changed, 9 insertions(+) diff --git a/waf_libbsd.py b/waf_libbsd.py index a817e574..bfe23845 100644 --- a/waf_libbsd.py +++ b/waf_libbsd.py @@ -55,6 +55,11 @@ if windows: else: host_shell = '' +def _add_flags_if_not_present(current_flags, addional_f