Re: [PATCH] bsps/powerpc: Fix small data area section

2019-02-11 Thread Chris Johns
On 11/2/19 11:59 pm, Sebastian Huber wrote: > On 11/02/2019 10:31, Chris Johns wrote: >>> You set the size for the small data area (name in the ABI documents). It >>> includes the .sdata and .sbss input sections and your libdl part. >> Some of this would great in a comment:) > > I checked in the p

Re: [PATCH] bsps/powerpc: Fix small data area section

2019-02-11 Thread Sebastian Huber
On 11/02/2019 10:31, Chris Johns wrote: You set the size for the small data area (name in the ABI documents). It includes the .sdata and .sbss input sections and your libdl part. Some of this would great in a comment:) I checked in the patch and added a comment to the top of linkcmds.base. -

Re: [PATCH] bsps/powerpc: Fix small data area section

2019-02-11 Thread Chris Johns
> On 11 Feb 2019, at 8:51 pm, Sebastian Huber > wrote: > >> On 11/02/2019 08:43, Chris Johns wrote: >>> On 11/2/19 7:38 pm, Sebastian Huber wrote: >>> Fix small data area in case no fixed size is desired. >> What is being fixed? > > Did you test without setting bsp_section_set_sdata_sbss_size

Re: [PATCH] bsps/powerpc: Fix small data area section

2019-02-10 Thread Sebastian Huber
On 11/02/2019 08:43, Chris Johns wrote: On 11/2/19 7:38 pm, Sebastian Huber wrote: Fix small data area in case no fixed size is desired. What is being fixed? Did you test without setting bsp_section_set_sdata_sbss_size? With bsp_section_sdata_sbss_size == 0 the location counter moves backwar

Re: [PATCH] bsps/powerpc: Fix small data area section

2019-02-10 Thread Chris Johns
On 11/2/19 7:38 pm, Sebastian Huber wrote: > Fix small data area in case no fixed size is desired. What is being fixed? > Rename > bsp_section_set_sdata_sbss_size into bsp_section_small_data_area_size > since this symbol reflects the overall small data area size (including > space for libdl). Th

[PATCH] bsps/powerpc: Fix small data area section

2019-02-10 Thread Sebastian Huber
Fix small data area in case no fixed size is desired. Rename bsp_section_set_sdata_sbss_size into bsp_section_small_data_area_size since this symbol reflects the overall small data area size (including space for libdl). Do not use bsp_section_sbss_size before definition in linker command file. A