Re: [PATCH] bsps/microblaze: Fix build option definition order

2022-07-08 Thread Sebastian Huber
On 07.07.22 21:19, Alex White wrote: The build option definitions were rearranged such that the option definitions used in the linker script were not available. This caused linker errors when building. Sorry for breaking the BSP. The patch looks good. -- embedded brains GmbH Herr Sebastian HUB

Re: [PATCH] bsps/microblaze: Fix build option definition order

2022-07-07 Thread Joel Sherrill
On Thu, Jul 7, 2022, 7:42 PM Chris Johns wrote: > On 8/7/2022 5:26 am, Joel Sherrill wrote: > > I'm ok with this but since you said Sebastian committed something which > broke > > this, it would be good for him to ack as well. > > > > Are there other BSPs which might have this issue? > > I am als

Re: [PATCH] bsps/microblaze: Fix build option definition order

2022-07-07 Thread Chris Johns
On 8/7/2022 5:26 am, Joel Sherrill wrote: > I'm ok with this but since you said Sebastian committed something which broke > this, it would be good for him to ack as well. > > Are there other BSPs which might have this issue? I am also wondering this. There is another patch Duc posted for ARM and

Re: [PATCH] bsps/microblaze: Fix build option definition order

2022-07-07 Thread Joel Sherrill
I'm ok with this but since you said Sebastian committed something which broke this, it would be good for him to ack as well. Are there other BSPs which might have this issue? On Thu, Jul 7, 2022 at 2:20 PM Alex White wrote: > The build option definitions were rearranged such that the option > d

[PATCH] bsps/microblaze: Fix build option definition order

2022-07-07 Thread Alex White
The build option definitions were rearranged such that the option definitions used in the linker script were not available. This caused linker errors when building. --- spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml | 2 -- spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.y