Re: [PATCH] bsps/lm32: Use shared

2020-07-30 Thread Sebastian Huber
On 30/07/2020 20:40, Gedare Bloom wrote: I think most of the BSPs have the pattern of /include/bsp/irq.h What is unusual about lm32 is that it has a shared one at include/bsp/irq.h I only see this in BSP directories that have one bsp. I think the shared irq.h should instead be removed/renamed.

Re: [PATCH] bsps/lm32: Use shared

2020-07-30 Thread Gedare Bloom
On Thu, Jul 30, 2020 at 12:40 PM Gedare Bloom wrote: > > I think most of the BSPs have the pattern of /include/bsp/irq.h > > What is unusual about lm32 is that it has a shared one at include/bsp/irq.h > > I only see this in BSP directories that have one bsp. I think the > shared irq.h should inste

Re: [PATCH] bsps/lm32: Use shared

2020-07-30 Thread Gedare Bloom
I think most of the BSPs have the pattern of /include/bsp/irq.h What is unusual about lm32 is that it has a shared one at include/bsp/irq.h I only see this in BSP directories that have one bsp. I think the shared irq.h should instead be removed/renamed. On Thu, Jul 30, 2020 at 11:35 AM Sebastian

[PATCH] bsps/lm32: Use shared

2020-07-30 Thread Sebastian Huber
Having a duplicate header with the shared includes is a build system inconsistency. You may use one header file to build the libraries and another one is installed (overwriting the other). Update #3269. --- bsps/lm32/lm32_evr/headers.am | 4 bsps/lm32/lm32_evr/include/bsp/irq.h | 1