Re: [PATCH] bootstrap: Do not create acinlude.m4 files

2018-04-23 Thread Chris Johns
On 23/4/18 5:07 pm, Sebastian Huber wrote: > On 23/04/18 08:51, Chris Johns wrote: >>> A RSB script >>> which modifies files of the repository is an extra error source. >> Why not remove `generate_bspdir_acinclude()` from the bootstrap script and we >> maintained the file by hand? After all adding

Re: [PATCH] bootstrap: Do not create acinlude.m4 files

2018-04-23 Thread Sebastian Huber
On 23/04/18 08:51, Chris Johns wrote: A RSB script which modifies files of the repository is an extra error source. Why not remove `generate_bspdir_acinclude()` from the bootstrap script and we maintained the file by hand? After all adding or removing BSPs from RTEMS is not done that often and i

Re: [PATCH] bootstrap: Do not create acinlude.m4 files

2018-04-22 Thread Chris Johns
On 23/04/2018 16:13, Sebastian Huber wrote: > On 23/04/18 08:05, Chris Johns wrote: >> On 23/04/2018 15:45, Sebastian Huber wrote: >>> The generation of files which are part of the Git repository should be >>> done by the normal bootstrap script only since this is a RTEMS >>> maintainer job. >> Rea

Re: [PATCH] bootstrap: Do not create acinlude.m4 files

2018-04-22 Thread Sebastian Huber
On 23/04/18 08:05, Chris Johns wrote: On 23/04/2018 15:45, Sebastian Huber wrote: The generation of files which are part of the Git repository should be done by the normal bootstrap script only since this is a RTEMS maintainer job. Really? I am a bit lost by this change. I have never understood

Re: [PATCH] bootstrap: Do not create acinlude.m4 files

2018-04-22 Thread Chris Johns
On 23/04/2018 15:45, Sebastian Huber wrote: > The generation of files which are part of the Git repository should be > done by the normal bootstrap script only since this is a RTEMS > maintainer job. Really? I am a bit lost by this change. I have never understood why acinclude.m4 is in the repo.

[PATCH] bootstrap: Do not create acinlude.m4 files

2018-04-22 Thread Sebastian Huber
The generation of files which are part of the Git repository should be done by the normal bootstrap script only since this is a RTEMS maintainer job. This patch is a part of the BSP source reorganization. Update #3285. --- source-builder/sb/bootstrap.py | 32 1 f