Re: [PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-07-15 Thread Joel Sherrill
On 7/15/2015 10:39 AM, Gedare Bloom wrote: the comments on the CPP lines. OK.. but is this a valid technical solution ignoring the style nits? :) On Wed, Jul 15, 2015 at 11:31 AM, Joel Sherrill wrote: OK but what about the patch itself technically? It was only subtracting a blank line so

Re: [PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-07-15 Thread Gedare Bloom
the comments on the CPP lines. On Wed, Jul 15, 2015 at 11:31 AM, Joel Sherrill wrote: > OK but what about the patch itself technically? > > It was only subtracting a blank line so once I fix that, > what else? > > > On 7/15/2015 2:59 AM, Sebastian Huber wrote: >> >> I tried to clarify the rules f

Re: [PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-07-15 Thread Joel Sherrill
OK but what about the patch itself technically? It was only subtracting a blank line so once I fix that, what else? On 7/15/2015 2:59 AM, Sebastian Huber wrote: I tried to clarify the rules for FreeBSD code changes: https://git.rtems.org/rtems-libbsd/commit/?id=a57dfa0dedc1f25c4dfd6e0c786a1dbf

Re: [PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-07-15 Thread Sebastian Huber
I tried to clarify the rules for FreeBSD code changes: https://git.rtems.org/rtems-libbsd/commit/?id=a57dfa0dedc1f25c4dfd6e0c786a1dbf72f44a03 On 15/07/15 00:42, Joel Sherrill wrote: --- freebsd/sys/contrib/altq/altq/altq_subr.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-)

[PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-07-14 Thread Joel Sherrill
--- freebsd/sys/contrib/altq/altq/altq_subr.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/freebsd/sys/contrib/altq/altq/altq_subr.c b/freebsd/sys/contrib/altq/altq/altq_subr.c index 3ebd58d..55f0977 100644 --- a/freebsd/sys/contrib/altq/altq/altq_subr.c +++ b/fr

Re: [PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-06-22 Thread Sebastian Huber
On 22/06/15 22:37, Gedare Bloom wrote: On Mon, Jun 22, 2015 at 4:36 PM, Gedare Bloom wrote: >On Mon, Jun 22, 2015 at 3:43 PM, Joel Sherrill > wrote: >>--- >> freebsd/sys/contrib/altq/altq/altq_subr.c |7 ++- >> 1 files changed, 6 insertions(+), 1 deletions(-) >> >>diff --git a/free

Re: [PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-06-22 Thread Gedare Bloom
On Mon, Jun 22, 2015 at 4:36 PM, Gedare Bloom wrote: > On Mon, Jun 22, 2015 at 3:43 PM, Joel Sherrill > wrote: >> --- >> freebsd/sys/contrib/altq/altq/altq_subr.c |7 ++- >> 1 files changed, 6 insertions(+), 1 deletions(-) >> >> diff --git a/freebsd/sys/contrib/altq/altq/altq_subr.c >>

Re: [PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-06-22 Thread Gedare Bloom
On Mon, Jun 22, 2015 at 3:43 PM, Joel Sherrill wrote: > --- > freebsd/sys/contrib/altq/altq/altq_subr.c |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/freebsd/sys/contrib/altq/altq/altq_subr.c > b/freebsd/sys/contrib/altq/altq/altq_subr.c > index 3ebd58d..55f

[PATCH] altq_subr.c: Disable x86 specific code on RTEMS

2015-06-22 Thread Joel Sherrill
--- freebsd/sys/contrib/altq/altq/altq_subr.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/freebsd/sys/contrib/altq/altq/altq_subr.c b/freebsd/sys/contrib/altq/altq/altq_subr.c index 3ebd58d..55f0977 100644 --- a/freebsd/sys/contrib/altq/altq/altq_subr.c +++ b/fr