Re: [PATCH] Updating trace buffer configuration

On 31/5/18 4:14 am, Sebastian Huber wrote: > - Am 30. Mai 2018 um 15:35 schrieb Amaan Cheval amaan.che...@gmail.com: > > [...] >> Minor, but in most other places in RTEMS, I've seen pointers declared >> with the asterisk on the variable not on the type ("int *ptr;" instead >> of "int* ptr;").

Re: [PATCH] Updating trace buffer configuration

On 31/5/18 1:35 am, Amaan Cheval wrote> Minor, but in most other places in RTEMS, I've seen pointers declared > with the asterisk on the variable not on the type ("int *ptr;" instead > of "int* ptr;"). I write code with the '*' on the type, after all it is an integer pointer (int* v;) and not a po

Re: [PATCH] Updating trace buffer configuration

- Am 30. Mai 2018 um 15:35 schrieb Amaan Cheval amaan.che...@gmail.com: [...] > Minor, but in most other places in RTEMS, I've seen pointers declared > with the asterisk on the variable not on the type ("int *ptr;" instead > of "int* ptr;"). [...] The int *ptr; is RTEMS-style, the int* ptr

Re: [PATCH] Updating trace buffer configuration

Vidushi, For revisions to patches, please use the "-v" option for git-format-patch before you git-send-email the patch files to append a version number, in this case, use git format-patch -v 2 HEAD^ -o ../ to generate a patch from the head commit in the parent directory having the "v2" appended to

Re: [PATCH] Updating trace buffer configuration

--- linkers/rtld-trace-buffer.ini | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linkers/rtld-trace-buffer.ini b/linkers/rtld-trace-buffer.ini index ee68d55..c17f2f1 100644 --- a/linkers/rtld-trace-buffer.ini +++ b/linkers/rtld-trace-buffer.ini @@ -27,6 +27,7 @@ header = "#i

Re: [PATCH] Updating trace buffer configuration

>Based on this error, I believe you need to drop the "struct", given >that Thread_Control is the typedef for "struct _Thread_Control". Oh yes you are right. It was originally written with the "struct" so I somehow overlooked it. I tired it this way. It works thanks. >Minor, but in most other plac

Re: [PATCH] Updating trace buffer configuration

On Wed, May 30, 2018 at 6:33 PM, Vidushi Vashishth wrote: > Could you please change the > > struct _Thread_Control > > to > > Thread_Control > > and check if it still works. > > In RTEMS, we use typedefs for structures in general. > > I tried to include the threadq.h header file so that I could us

Re: [PATCH] Updating trace buffer configuration

Could you please change the struct _Thread_Control to Thread_Control and check if it still works. In RTEMS, we use typedefs for structures in general. I tried to include the threadq.h header file so that I could use the variable Thread_Control instead of _Thread_Control. This header file has

Re: [PATCH] Updating trace buffer configuration

On 29/05/18 17:36, Vidushi Vashishth wrote: --- linkers/rtld-trace-buffer.ini | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linkers/rtld-trace-buffer.ini b/linkers/rtld-trace-buffer.ini index af9fc31..ee68d55 100644 --- a/linkers/rtld-trace-buffer.ini +++ b/linkers

[PATCH] Updating trace buffer configuration

--- linkers/rtld-trace-buffer.ini | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linkers/rtld-trace-buffer.ini b/linkers/rtld-trace-buffer.ini index af9fc31..ee68d55 100644 --- a/linkers/rtld-trace-buffer.ini +++ b/linkers/rtld-trace-buffer.ini @@ -26,6 +26,7 @@ buffer-lo