Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Gedare Bloom
Squash, and send with -v2 https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch Use --subject-prefix="PATCH rtems-lwip" We expect there will be things installed. It is expected only one network stack will be installed in a given PREFIX. We haven't quite gotten to the point of

Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Robin Müller
I integrated most of your points and added waf support. The lwIP support can now be installed like the RTEMS BSP with waf so the PKG Config generated by the BSP installation can be reused. It puts some folders like lwip / netif / compat into the include path, I hope this is not problematic. I'll s

Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Robin Müller
Small correction: I changed the ethernetif.c file to be usable by all three major APIs. Kind Regards Robin On Wed, 28 Apr 2021 at 11:55, Robin Müller wrote: > Should I provide the changes for the code review as a separate patch or > should I squash them again? > > Using the upstream unchanged i

Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Robin Müller
Should I provide the changes for the code review as a separate patch or should I squash them again? Using the upstream unchanged is tricky because the code was taken from the examples and these examples are always targeted towards a specific API. I changed the version to be usable by both APIs. I

Re: [PATCH] STM32 lwIP addition

2021-04-27 Thread Gedare Bloom
On Tue, Apr 27, 2021 at 2:09 PM Gedare Bloom wrote: > > On Tue, Apr 27, 2021 at 11:41 AM Robin Mueller > wrote: > > I'm not sure what happened, it looks like my email client garbled the inline threaded reply. Hopefully my comments come through for you ok.

Re: [PATCH] STM32 lwIP addition

2021-04-27 Thread Gedare Bloom
On Tue, Apr 27, 2021 at 11:41 AM Robin Mueller wrote: > > This patch adds the STM32H7 / NUCLEO-H743ZI lwIP port. > It also improves the architecture to make integration > of new BSPs easier. > > https://github.com/rmspacefish/rtems-stm32-lwip is a self-contained > repository to test the lwIP integ

[PATCH] STM32 lwIP addition

2021-04-27 Thread Robin Mueller
This patch adds the STM32H7 / NUCLEO-H743ZI lwIP port. It also improves the architecture to make integration of new BSPs easier. https://github.com/rmspacefish/rtems-stm32-lwip is a self-contained repository to test the lwIP integration for the arm/stm32h7 and arm/nucleo-h743zi BSP. The STM32 por

[PATCH] STM32 lwIP addition and CMake support

2021-04-24 Thread Robin Mueller
This patch adds CMake support to RTEMS lwIP. It also improves the architecture to make integration of new BSPs easier. https://github.com/rmspacefish/rtems-stm32-lwip is a self-contained repository to test the lwIP integration for the arm/stm32h7 and arm/nucleo-h743zi BSP. The STM32 port includes