Re: [PATCH] Remove superfluous run-time check

2019-04-07 Thread Sebastian Huber
On 05/04/2019 16:40, Joel Sherrill wrote: Are you sure it can't be NULL when POSIX is disabled? The historical case where it was NULL was when you disabled an API. It cannot be NULL: Objects_Information ** const _Objects_Information_table[ OBJECTS_APIS_LAST + 1 ] = {   NULL,   &_Internal_Objec

Re: [PATCH] Remove superfluous run-time check

2019-04-05 Thread Joel Sherrill
Are you sure it can't be NULL when POSIX is disabled? The historical case where it was NULL was when you disabled an API. If it truly can't be NULL now, it would be good to see comments that explain why it can't be NULL. On Fri, Apr 5, 2019 at 3:00 AM Sebastian Huber < sebastian.hu...@embedded-br

[PATCH] Remove superfluous run-time check

2019-04-05 Thread Sebastian Huber
The _Objects_Information_table[ the_api ] is never NULL for a valid API index. --- cpukit/posix/src/killinfo.c | 8 +--- cpukit/score/src/threaditerate.c | 5 + 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/cpukit/posix/src/killinfo.c b/cpukit/posix/src/killinfo.c in