Re: [PATCH] Fix for Beaglebone BSP PWM bug

Hi Christian, Thanks very much for that, much appreciated. Cheers, James On Tue, 14 Jul 2020, 03:52 Christian Mauderer, wrote: > > > On 13/07/2020 11:55, James Fitzsimons wrote: > > Hi Christian and Chris, > > > > On Sun, 12 Jul 2020 at 06:27, Christian Mauderer > >

Re: [PATCH] Fix for Beaglebone BSP PWM bug

On 13/07/2020 11:55, James Fitzsimons wrote: > Hi Christian and Chris, > > On Sun, 12 Jul 2020 at 06:27, Christian Mauderer > wrote: > > Hello Fitzsimons, > > sorry for the late review and thanks Chris for poking me. > > I have some troubles understandi

Re: [PATCH] Fix for Beaglebone BSP PWM bug

Hi Christian and Chris, On Sun, 12 Jul 2020 at 06:27, Christian Mauderer wrote: > Hello Fitzsimons, > > sorry for the late review and thanks Chris for poking me. > > I have some troubles understanding the patch and the current code: > > == Regarding your patch: > > There is no pin GPMC_AD(18) or

Re: [PATCH] Fix for Beaglebone BSP PWM bug

Hello Fitzsimons, sorry for the late review and thanks Chris for poking me. I have some troubles understanding the patch and the current code: == Regarding your patch: There is no pin GPMC_AD(18) or GPMC_AD(19). That offset will lead you to the pins GPMC_A8 and GPMC_A9. The correct macros to us

Re: [PATCH] Fix for Beaglebone BSP PWM bug

On 5/7/20 8:43 pm, James Fitzsimons wrote: > > I hope that patch is ok, that was my first time using git send-email. > It looks OK to me but I would like Christian to approve it. > This patch fixes a bug in the Beaglebone BSP where the register offsets for > the > PWM outputs on header pins P9

Re: [PATCH] Fix for Beaglebone BSP PWM bug

Hi all, I hope that patch is ok, that was my first time using git send-email. This patch fixes a bug in the Beaglebone BSP where the register offsets for the PWM outputs on header pins P9_14 and P9_16 are incorrectly calculated. I'm about to start work on adding the QEP driver to the beaglebone

[PATCH] Fix for Beaglebone BSP PWM bug

--- Fixed incorrect register offset values for EHRPWM1A on P9_14 and EHRPWM1B on P9_16 bsps/arm/beagle/pwm/pwm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/arm/beagle/pwm/pwm.c b/bsps/arm/beagle/pwm/pwm.c index 0bc5d125bf..9a346995aa 100644 --- a/bsps/arm/beagle