Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Joel Sherrill
On 9/2/2015 8:43 AM, Martin Galvan wrote: On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote: Joel, Coordinate your patch/fixes with this patch. (I do prefer the separate patches that Joel gave. Small atomic commits are better.) Gedare I thought he'd seen this e-mail :) I agree that small

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Martin Galvan
On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote: > Joel, > Coordinate your patch/fixes with this patch. (I do prefer the separate > patches that Joel gave. Small atomic commits are better.) > Gedare I thought he'd seen this e-mail :) I agree that small atomic commits are better. However, the

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Gedare Bloom
Joel, Coordinate your patch/fixes with this patch. (I do prefer the separate patches that Joel gave. Small atomic commits are better.) Gedare On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom wrote: > Apply to 4.11 and master > > On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom wrote: >> Looks OK to me.

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Gedare Bloom
Apply to 4.11 and master On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom wrote: > Looks OK to me. > > On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan > wrote: >> This patch fixes the following CppCheck errors found throughout the code: >> >> [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid n

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Gedare Bloom
Looks OK to me. On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan wrote: > This patch fixes the following CppCheck errors found throughout the code: > > [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of character > ({) when these macros are defined: '__cplusplus'. > [cpukit/libmisc

[PATCH] Fix CppCheck errors

2015-09-01 Thread Martin Galvan
This patch fixes the following CppCheck errors found throughout the code: [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of character ({) when these macros are defined: '__cplusplus'. [cpukit/libmisc/dumpbuf/dumpbuf.c:69]: (error) Undefined behavior: Variable 'line_buffer' is u