Re: [PATCH] Add model file for Coverity

2021-01-28 Thread Sebastian Huber
On 28/01/2021 20:29, Joel Sherrill wrote: I'm still not getting emails when the runs are finished but it looks like it is done. Thanks for starting a new run with the updated file. It seems the #define stuff in the model file didn't work. For example, we still have CID 1399745. You can expan

Re: [PATCH] Add model file for Coverity

2021-01-28 Thread Joel Sherrill
I'm still not getting emails when the runs are finished but it looks like it is done. FWIW spi-sd-card.c seems to be the one I see everytime I load the defect page. The three in spi-sd-card.c look legitimate. Not sure what your approach is for nibbling at them but at first glance, those look fixab

Re: [PATCH] Add model file for Coverity

2021-01-28 Thread Joel Sherrill
On Thu, Jan 28, 2021 at 1:11 PM Joel Sherrill wrote: > > > On Thu, Jan 28, 2021 at 12:44 PM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> On 28/01/2021 19:42, Sebastian Huber wrote: >> >> > +#define _CPU_Fatal_halt( _source, _error ) \ >> > + do { \ >> > +(void) _source

Re: [PATCH] Add model file for Coverity

2021-01-28 Thread Joel Sherrill
On Thu, Jan 28, 2021 at 12:44 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 28/01/2021 19:42, Sebastian Huber wrote: > > > +#define _CPU_Fatal_halt( _source, _error ) \ > > + do { \ > > +(void) _source; \ > > +(void) _error; \ > > +__coverity_panic__(); \ > > +

Re: [PATCH] Add model file for Coverity

2021-01-28 Thread Sebastian Huber
On 28/01/2021 19:42, Sebastian Huber wrote: +#define _CPU_Fatal_halt( _source, _error ) \ + do { \ +(void) _source; \ +(void) _error; \ +__coverity_panic__(); \ + } while( 0 ) I am not sure if #define works for the models. The documentation mentions only real functions and types

[PATCH] Add model file for Coverity

2021-01-28 Thread Sebastian Huber
--- static-analysis/coverity/model.c | 63 1 file changed, 63 insertions(+) create mode 100644 static-analysis/coverity/model.c diff --git a/static-analysis/coverity/model.c b/static-analysis/coverity/model.c new file mode 100644 index 000..cd25d2b --- /dev/n