Re: [Bugfix rtems-lwip 4/4] Fix crash due to link_detect_thread

2024-04-02 Thread Kinsey Moore
I'd have to see what you're describing. If you'd like, I can reformulate the patch as well. Kinsey On Tue, Apr 2, 2024 at 2:51 AM Bernd Moessner wrote: > Is it ok to implement it using a single ifdef __rtems__ else ? The driver > is already a ifdef - hell and it will become even less readable w

Re: [Bugfix rtems-lwip 4/4] Fix crash due to link_detect_thread

2024-04-02 Thread Bernd Moessner
Is it ok to implement it using a single ifdef __rtems__ else ? The driver is already a ifdef - hell and it will become even less readable when I add even more of them. Kinsey Moore schrieb am Mo., 1. Apr. 2024, 16:39: > The intent of this patch is fine, but changes should be purely additive > an

Re: [Bugfix rtems-lwip 4/4] Fix crash due to link_detect_thread

2024-04-01 Thread Kinsey Moore
The intent of this patch is fine, but changes should be purely additive and properly wrapped in the __rtems__ check. The addition of thread startup at the end should also be wrapped in !NO_SYS. Kinsey On Sun, Mar 31, 2024 at 5:49 PM Bernd Moessner wrote: > Within xemac_add, the link_detect_thre

[Bugfix rtems-lwip 4/4] Fix crash due to link_detect_thread

2024-03-31 Thread Bernd Moessner
Within xemac_add, the link_detect_thread is set up before the ethernet interface is configured and all data structures have been set up correctly. The steps within xemac_add are basically: 1) Set up link_detect_thread 2) Initialize the interface 3) Set up the link speed / start autonegotiation 4) W