Re: [PATCH v2] cpukit/score: Avoid overflow in multiplication

2024-01-17 Thread Sebastian Huber
On 17.01.24 15:31, Kinsey Moore wrote: Change extend_count to uint32_t from uint16_t to avoid a possible premature integer overflow when it is later used for multiplication. Thanks, looks good. -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: se

[PATCH v2] cpukit/score: Avoid overflow in multiplication

2024-01-17 Thread Kinsey Moore
Change extend_count to uint32_t from uint16_t to avoid a possible premature integer overflow when it is later used for multiplication. --- cpukit/score/src/objectextendinformation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/src/objectextendinformation.c b/cp

Re: [PATCH] cpukit/score: Avoid overflow in multiplication

2024-01-17 Thread Kinsey Moore
Fair enough. I'll update the patch. Thanks! On Wed, Jan 17, 2024 at 12:45 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 16.01.24 21:02, Kinsey Moore wrote: > > The two operands are 16 bit and the result is being saved into a > > larger type. Reduce the possibility of an ove

Re: Convert test executables to bootloader images?

2024-01-17 Thread Sebastian Huber
Hello, attached is a proof of concept. Using a ./waf bootimages command didn't work since you don't have a build context in this case. I added a new option: # If this option is enabled, then boot images for the test programs # are built. BUILD_BOOT_IMAGES = False If this option is enabled, t

[PATCH] build: Fix script action

2024-01-17 Thread Sebastian Huber
We have to use a custom dictorary to be able to set the "value" argument in the exec() context. --- wscript | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/wscript b/wscript index a71e0d3f10..6c81083b2c 100755 --- a/wscript +++ b/wscript @@ -1026,8 +1026,14 @@ class

[PATCH v1] bsps/aarch64: explicit cast uint64_t to ISR_Level

2024-01-17 Thread tianye
From: Chengxiang Li avoid pclint err --- cpukit/score/cpu/aarch64/include/rtems/score/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/aarch64/include/rtems/score/cpu.h b/cpukit/score/cpu/aarch64/include/rtems/score/cpu.h index aa4f90f1a8..569b6bcee2 10