added unit tests and shorten long lines.
---
rtemstoolkit/execute.py | 43 -
1 file changed, 38 insertions(+), 5 deletions(-)
diff --git a/rtemstoolkit/execute.py b/rtemstoolkit/execute.py
index ed81589..9ec1cd7 100755
--- a/rtemstoolkit/execute.py
+++ b/r
Sorry, sent the wrong patch, it should be the v2. Ignore this one.
On Tue, Jun 20, 2023 at 12:30 PM Muhammad Sulthan Mazaya <
msulthanmaz...@gmail.com> wrote:
> The previous implementation of execute command on rtems-tools config does
> not support command line pipe operation. So something like:
The previous implementation of execute command on rtems-tools config does
not support command line pipe operation. So something like:
%execute %{command} | %{trim_command}
Would not work, since the "| %{trim_command}" part is treated as an
additional command option. This patch is intended to fix
Hi,
Thanks for this. I like the change.
Could you please shorten the long line? This code will be run through yapf after
6 branches but until then we limit the line length. :)
Could you please add a unit test for this to the end of this file?
Thanks
Chris
On 20/6/2023 8:44 am, Muhammad Sulthan
The regular split-by-space function used to split command arguments
creates compatibility issues with many shell command syntaxes. A
specific example is the handling of string arguments, as shown below:
%define renode_args -e start_opts -e "s %{bsp_resc_script}"
Thus, it is changed to use shlex.s
The previous implementation of execute command on rtems-tools config does
not support command line pipe operation. So something like:
%execute %{command} | %{trim_command}
Would not work, since the "| %{trim_command}" part is treated as an
additional command option. This patch is intended to fix