Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Aaron Nyholm
This looks exciting. As for Versal support from Xilinx's Docs "RPU The real-time processing unit (RPU) Arm Cortex-R5F processor has faster clocking frequencies than the Zynq UltraScale+ MPSoC. The Versal Arm Cortex-R5F processor supports Vector Floating-Point v3 (VFPv3) whereas the Zynq UltraS

[PATCH] rtemsbsd/versal_slcr: Fix Versal GEM clock set

2023-06-14 Thread aaron . nyholm
From: Aaron Nyholm --- rtemsbsd/sys/arm64/xilinx/versal_slcr.c | 34 ++--- rtemsbsd/sys/arm64/xilinx/versal_slcr.h | 6 + 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/rtemsbsd/sys/arm64/xilinx/versal_slcr.c b/rtemsbsd/sys/arm64/xilinx/versal_slcr.c in

rtemsbsd/versal_slcr: Fix Versal GEM clock set

2023-06-14 Thread aaron . nyholm
On the Versal when the GEM clock is routed from a PLL in another domain it goes through another clock divider. This check accounts for this extra clock divider when setting the clock. Thanks, Aaron. ___ devel mailing list devel@rtems.org http://lists.r

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Chris Johns
On 14/6/2023 6:08 pm, Philip Kirkpatrick wrote: > This patch adds support for running RTEMS on the RPU (cortex R5) cores of the > ZynqMP.  Thanks for submitting this BSP. It is exciting to see this work and support being added. How different are the ZynqMP RPU cores and the ones on the Versal? I

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

2023-06-14 Thread Gedare Bloom
On Wed, Jun 14, 2023 at 11:59 AM Sebastian Huber wrote: > > On 14.06.23 18:13, Gedare Bloom wrote: > >>> I think we should have some of the BSP-specific tests under some other > >>> location in testsuites, while others would be under validation where > >>> they are used for pre-qualification? > >>

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

2023-06-14 Thread Sebastian Huber
On 14.06.23 18:13, Gedare Bloom wrote: I think we should have some of the BSP-specific tests under some other location in testsuites, while others would be under validation where they are used for pre-qualification? Maybe it is sensible to introduce testsuites/bsps/ also. For the unit tests I w

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread mbenson
This is great. I will carve out time to check this out on the ZU3EG and provide feedback if needed. Good job. Sent from my iPhone > On Jun 14, 2023, at 08:49, Joel Sherrill wrote: > >  > Thanks for submitting this. It has been on the wish list for a while. > > My first comment is that info

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Kinsey Moore
Overall, this looks like great work! Thanks for contributing! Just a couple of addons to Joel's comments below. On Wed, Jun 14, 2023 at 8:49 AM Joel Sherrill wrote: > > On Wed, Jun 14, 2023 at 3:08 AM Philip Kirkpatrick < > p.kirkpatr...@reflexaerospace.com> wrote: > > diff --git a/bsps/arm/xil

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

2023-06-14 Thread Gedare Bloom
On Tue, Jun 13, 2023 at 8:56 AM Sebastian Huber wrote: > > > > On 12.06.23 17:58, Gedare Bloom wrote: > > On Mon, Jun 12, 2023 at 12:56 AM Sebastian Huber > > wrote: > >> > >> > >> > >> On 01.06.23 22:06, Gedare Bloom wrote: > >>> On Thu, Jun 1, 2023 at 2:00 PM Gedare Bloom wrote: > ---

Re: style question: breaking inline assembly lines

2023-06-14 Thread Gedare Bloom
On Tue, Jun 13, 2023 at 7:41 PM Chris Johns wrote: > > On 14/6/2023 10:20 am, Joel Sherrill wrote: > > > > > > On Tue, Jun 13, 2023, 4:43 PM Chris Johns > > wrote: > > > > On 14/6/2023 5:47 am, Joel Sherrill wrote: > > > > > > > > > On Tue, Jun 13, 2023 at

Re: style question: breaking inline assembly lines

2023-06-14 Thread Gedare Bloom
On Tue, Jun 13, 2023 at 8:51 AM Sebastian Huber wrote: > > On 13.06.23 00:04, Gedare Bloom wrote: > > "b _ARM_Exception_default\n" > > : > > -: [cpufsz] "i" (sizeof(CPU_Exception_frame)), > > - [cpuspoff] "i" (offsetof(CPU_Exception_frame, register_sp)), > > - [v7mlroff]

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Joel Sherrill
Thanks for submitting this. It has been on the wish list for a while. My first comment is that information needs to be added to the Users Guide on this BSP. Guidance on capabilities, use, and debug is always appreciated by the next user. Remember that often this is where search engines and other h

bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Philip Kirkpatrick
This patch adds support for running RTEMS on the RPU (cortex R5) cores of the ZynqMP. This is only a basic BSP and does not yet support the following: - SMP - Cache - MPU Also, everything except for the startup and exception vectors runs out of DRAM, which is slow without cache. At some point in