Re: [rtems commit] spec/librtemscpu: Fix installed headers

2022-08-30 Thread Chris Johns
On 31/8/2022 4:57 am, Sebastian Huber wrote: > On 30/08/2022 19:55, Joel Sherrill wrote: >> On Tue, Aug 30, 2022 at 8:12 AM Sebastian Huber >> > > wrote: >> >>     On 22/08/2022 01:30, Chris Johns wrote: >> > - keyimpl.h is not referenced and so not n

Re: [PATCH rtems-lwip] lwip.py: Track includes as lists

2022-08-30 Thread Chris Johns
OK Thanks Chris On 31/8/2022 3:21 am, Kinsey Moore wrote: > The original work for rtems-lwip tracked include directories as raw > strings to be passed into the build infrastructure. This reformulates > include directory management as lists to reduce errors in future > changes. > --- > lwip.py |

Re: [PATCH rtems-lwip] lwip.py: Address python formatting issues

2022-08-30 Thread Chris Johns
On 30/8/2022 11:09 pm, Kinsey Moore wrote: > I'll go ahead and get this committed and then address the strings issue in > another patch. Good idea. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

rtems-central appears to be out of sync with rtems and rtems-docs

2022-08-30 Thread Joel Sherrill
Hi When I am on master of rtems-central.git and sub spec2modules.py, it generates updates to rtems-docs and rtems. My understanding is that if they were in sync, there would be no changes in rtems-docs and rtems. (env) [joel@localhost rtems-central]$ ./spec2modules.py (env) [joel@localhost rtems-

Re: [PATCH v5 0/1] NOEL-V BSP

2022-08-30 Thread Joel Sherrill
And then Sebastian replies while I was typing that. Address his concerns. :) On Tue, Aug 30, 2022 at 2:10 PM Joel Sherrill wrote: > I think it's OK to push after this long. > > Also be sure to add some to the RTEMS Users Guide for this BSP. > > Does this work on any simulator? > > --joel > > On

Re: [PATCH v5 0/1] NOEL-V BSP

2022-08-30 Thread Joel Sherrill
I think it's OK to push after this long. Also be sure to add some to the RTEMS Users Guide for this BSP. Does this work on any simulator? --joel On Tue, Aug 30, 2022 at 6:39 AM Daniel Cederman wrote: > Hi, > > Is it OK to push this or should I wait for additional comments? > > On 2022-08-25 1

Re: [PATCH v5 1/1] bsp/riscv: Add NOEL-V BSP

2022-08-30 Thread Sebastian Huber
On 25/08/2022 10:33, Daniel Cederman wrote: +#define BSP_INTERRUPT_VECTOR_MIN 0 + +#define BSP_INTERRUPT_VECTOR_MAX RISCV_INTERRUPT_VECTOR_EXTERNAL(RISCV_MAXIMUM_EXTERNAL_INTERRUPTS - 1) I am a bit surprised that this worked, since the API changed. The BSP should define #define BSP_INTERRUP

Re: [PATCH] Fix pedanic warnings without a storage increase

2022-08-30 Thread Sebastian Huber
On 30/08/2022 19:45, Joel Sherrill wrote: On Tue, Aug 30, 2022 at 9:40 AM Sebastian Huber > wrote: On 30/08/2022 16:38, Joel Sherrill wrote: >     +  /* >     +   * Ignore these warnings: >     +   * >     +   * - invalid use

Re: [rtems commit] spec/librtemscpu: Fix installed headers

2022-08-30 Thread Sebastian Huber
On 30/08/2022 19:55, Joel Sherrill wrote: On Tue, Aug 30, 2022 at 8:12 AM Sebastian Huber > wrote: On 22/08/2022 01:30, Chris Johns wrote: > - keyimpl.h is not referenced and so not needed We install all the *impl.h header files. Why shou

Re: New Defects reported by Coverity Scan for RTEMS

2022-08-30 Thread Sebastian Huber
On 30/08/2022 19:48, Joel Sherrill wrote: On Tue, Aug 30, 2022 at 9:53 AM Sebastian Huber > wrote: On 30/08/2022 16:37, Joel Sherrill wrote: > > On Tue, Aug 30, 2022 at 8:44 AM Sebastian Huber > mailto:sebastian.hu...@embedded

Re: [rtems commit] spec/librtemscpu: Fix installed headers

2022-08-30 Thread Joel Sherrill
On Tue, Aug 30, 2022 at 8:12 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 22/08/2022 01:30, Chris Johns wrote: > > - keyimpl.h is not referenced and so not needed > > We install all the *impl.h header files. Why should keyimpl.h be an > exception? > I'd lean to installing

Re: New Defects reported by Coverity Scan for RTEMS

2022-08-30 Thread Joel Sherrill
On Tue, Aug 30, 2022 at 9:53 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 30/08/2022 16:37, Joel Sherrill wrote: > > > > On Tue, Aug 30, 2022 at 8:44 AM Sebastian Huber > > > > wrote: > > > > On 30/08/2022 15:40, Joel Sher

Re: [PATCH] Fix pedanic warnings without a storage increase

2022-08-30 Thread Joel Sherrill
On Tue, Aug 30, 2022 at 9:40 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 30/08/2022 16:38, Joel Sherrill wrote: > > + /* > > + * Ignore these warnings: > > + * > > + * - invalid use of structure with flexible array member > > + * > > + *

[PATCH rtems-lwip] lwip.py: Track includes as lists

2022-08-30 Thread Kinsey Moore
The original work for rtems-lwip tracked include directories as raw strings to be passed into the build infrastructure. This reformulates include directory management as lists to reduce errors in future changes. --- lwip.py | 130 +--- 1 file cha

Re: New Defects reported by Coverity Scan for RTEMS

2022-08-30 Thread Sebastian Huber
On 30/08/2022 16:37, Joel Sherrill wrote: On Tue, Aug 30, 2022 at 8:44 AM Sebastian Huber > wrote: On 30/08/2022 15:40, Joel Sherrill wrote: > > > On Tue, Aug 30, 2022 at 12:05 AM Sebastian Huber > mailto:sebastian.hu...@emb

Re: [PATCH] Fix pedanic warnings without a storage increase

2022-08-30 Thread Sebastian Huber
On 30/08/2022 16:38, Joel Sherrill wrote: +  /* +   * Ignore these warnings: +   * +   * - invalid use of structure with flexible array member +   * +   * - struct has no members +   */ +  #pragma GCC diagnostic push +  #pragma GCC diagnostic ignored "-Wpedanti

Re: [PATCH] Fix pedanic warnings without a storage increase

2022-08-30 Thread Joel Sherrill
On Tue, Aug 30, 2022 at 1:10 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Use RTEMS_ZERO_LENGTH_ARRAY for flexible array member. > > Update #4662. > --- > cpukit/include/rtems/confdefs/scheduler.h | 10 ++ > cpukit/include/rtems/score/schedulerpriority.h | 2 +-

Re: New Defects reported by Coverity Scan for RTEMS

2022-08-30 Thread Joel Sherrill
On Tue, Aug 30, 2022 at 8:44 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 30/08/2022 15:40, Joel Sherrill wrote: > > > > > > On Tue, Aug 30, 2022 at 12:05 AM Sebastian Huber > > > > wrote: > > > > On 30/08/2022 00:56, scan-ad.

Re: New Defects reported by Coverity Scan for RTEMS

2022-08-30 Thread Sebastian Huber
On 30/08/2022 15:40, Joel Sherrill wrote: On Tue, Aug 30, 2022 at 12:05 AM Sebastian Huber > wrote: On 30/08/2022 00:56, scan-ad...@coverity.com wrote: > ** CID 1512552:  High impact quality  (Y2K38_SAFE

Re: New Defects reported by Coverity Scan for RTEMS

2022-08-30 Thread Joel Sherrill
On Tue, Aug 30, 2022 at 12:05 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 30/08/2022 00:56, scan-ad...@coverity.com wrote: > > ** CID 1512552: High impact quality (Y2K38_SAFETY) > > /cpukit/score/src/kern_tc.c: 1804 in _Timecounter_Windup() > > > > > > >

Re: [rtems commit] spec/librtemscpu: Fix installed headers

2022-08-30 Thread Sebastian Huber
On 22/08/2022 01:30, Chris Johns wrote: - keyimpl.h is not referenced and so not needed We install all the *impl.h header files. Why should keyimpl.h be an exception? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de p

Re: [PATCH rtems-lwip] lwip.py: Address python formatting issues

2022-08-30 Thread Kinsey Moore
On 8/29/2022 17:06, Chris Johns wrote: On 30/8/2022 4:30 am, Kinsey Moore wrote: --- lwip.py | 106 1 file changed, 61 insertions(+), 45 deletions(-) diff --git a/lwip.py b/lwip.py index f8d8eb0..2e12957 100644 --- a/lwip.py +++ b/lwip

Re: [PATCH v5 0/1] NOEL-V BSP

2022-08-30 Thread Daniel Cederman
Hi, Is it OK to push this or should I wait for additional comments? On 2022-08-25 10:33, Daniel Cederman wrote: v5 Made RISCV_CONSOLE_MAX_APBUART_DEVICES an option bsp_fatal if no uart clock frequency is found Changed CONSOLE_USE_INTERRUPTS to BSP_CONSOLE_USE_INTERRUPTS Added error codes for AP