Re: [PATCH] libdl: Refactor shared code in Arm and AArch64

2022-07-28 Thread Chris Johns
OK Nice change and clean up. Thanks Chris On 29/7/2022 1:04 am, Ryan Long wrote: > rtl-mdreloc-arm.c was used as the basis for rtl-mdreloc-aarch64.c. This lead > to some code being shared by the two files. The code was consolidated into > rtl-unwind-arm.c. > > Closes #4686 > --- > cpukit/libdl

Re: [PATCH v3 0/5] Add AArch64 support to libdl

2022-07-28 Thread Chris Johns
OK Thank you for the contribution. It is appreciated and a welcome addition. Chris On 28/7/2022 11:05 pm, Ryan Long wrote: > Hi, > > In this version of the patchset I just removed the line that was setting the > objects loader to NULL. > > Thanks, > Ryan > > Ryan Long (5): > sys/exec_elf.h:

[PATCH] libdl: Refactor shared code in Arm and AArch64

2022-07-28 Thread Ryan Long
rtl-mdreloc-arm.c was used as the basis for rtl-mdreloc-aarch64.c. This lead to some code being shared by the two files. The code was consolidated into rtl-unwind-arm.c. Closes #4686 --- cpukit/libdl/rtl-mdreloc-aarch64.c | 79 +- cpukit/libdl/rtl-mdreloc-arm.c | 7

[PATCH v3 0/5] Add AArch64 support to libdl

2022-07-28 Thread Ryan Long
Hi, In this version of the patchset I just removed the line that was setting the objects loader to NULL. Thanks, Ryan Ryan Long (5): sys/exec_elf.h: Bring in newer file libdl/rtl-elf.h: Fix aarch64 define cpukit/libdl: Add support for AArch64 libtests/dl*: Bump up the size of CONFIGURE_I

[PATCH v3 1/5] sys/exec_elf.h: Bring in newer file

2022-07-28 Thread Ryan Long
Updated this file with the newer version in NetBSD. Updates #4682 --- cpukit/include/sys/exec_elf.h | 840 -- 1 file changed, 608 insertions(+), 232 deletions(-) diff --git a/cpukit/include/sys/exec_elf.h b/cpukit/include/sys/exec_elf.h index 4242415f54..b50da6b27

[PATCH v3 4/5] libtests/dl*: Bump up the size of CONFIGURE_INIT_TASK_STACK_SIZE

2022-07-28 Thread Ryan Long
Updates #4682 --- testsuites/libtests/dl01/init.c | 2 +- testsuites/libtests/dl02/init.c | 2 +- testsuites/libtests/dl03/init.c | 2 +- testsuites/libtests/dl04/init.c | 2 +- testsuites/libtests/dl05/init.c | 2 +- testsuites/libtests/dl06/initimpl.h | 2 +- testsuites/libte

[PATCH v3 3/5] cpukit/libdl: Add support for AArch64

2022-07-28 Thread Ryan Long
rtl-mdreloc-aarch64.c and elf_machdep.h came from NetBSD. Updates #4682 --- cpukit/libdl/rtl-mdreloc-aarch64.c| 598 ++ .../cpu/aarch64/include/machine/elf_machdep.h | 256 spec/build/cpukit/objdl.yml | 2 + spec/build/cpukit/objdlaarch64.y

[PATCH v3 5/5] cpukit/libdl/rtl-sym.c: Fix increment of variable

2022-07-28 Thread Ryan Long
In rtems_rtl_symbol_global_add() the loop that gets to the end of the symbol table used "unsigned long" to increment the index for the table. For most architectures this resulted in 4, but with AArch64, it results in 8. This resulted in the symbols being read in wrong. Changing this to void* along

[PATCH v3 2/5] libdl/rtl-elf.h: Fix aarch64 define

2022-07-28 Thread Ryan Long
The aarch64 define was incorrect. This was causing the libdl tests to not work correctly. Updates #4682 --- cpukit/libdl/rtl-elf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libdl/rtl-elf.h b/cpukit/libdl/rtl-elf.h index c7c17c525a..0476c1ecd7 100644 --- a/cpukit/l

Re: [PATCH v3] aarch64/versal: Support DDRMC0 region 0 and 1

2022-07-28 Thread Chris Johns
On 28/7/2022 4:57 pm, Sebastian Huber wrote: > Hello, > > I get now linker errors: > > /opt/rtems/6/lib/gcc/aarch64-rtems6/12.1.1/../../../../aarch64-rtems6/bin/ld: > ./librtemsbsp.a(bspstartmmu.c.7.o):(.rodata.bsp_r1_region+0x0): undefined > reference to `bsp_r1_ram_base' > /opt/rtems/6/lib/gcc/