Re: [gcc] Enable TLS support for RTEMS in libstdc++

2022-06-08 Thread Sebastian Huber
On 08/06/2022 16:18, Sebastian Huber wrote: On 08/06/2022 16:11, Joel Sherrill wrote: On Wed, Jun 8, 2022 at 8:47 AM Sebastian Huber > wrote:     On 08/06/2022 15:39, Joel Sherrill wrote: > Is TLS actually supported on all targets except MIPS?

Re: [PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-08 Thread Sebastian Huber
On 08/06/2022 18:09, Joel Sherrill wrote: On Wed, Jun 8, 2022, 10:45 AM Gedare Bloom > wrote: Does this code have an upstream? I tried to find it. Maybe whoever added it has memory of the source. As best I can tell, it is lightly or not maintained reference code

Re: [PATCH 5/5] testsuites/libtests/malloctest: fix warning

2022-06-08 Thread Sebastian Huber
On 08/06/2022 15:34, Matthew Joyce wrote: @@ -118,13 +116,6 @@ static void test_realloc(void) malloc_walk_ok = malloc_walk( 1234, false ); rtems_test_assert( malloc_walk_ok ); _Thread_Dispatch_enable( _Per_CPU_Get() ); - - /* - * Realloc with a bad pointer to force a point - */

Re: [PATCH] validation: Fix CallWithinISR()

2022-06-08 Thread Sebastian Huber
On 08/06/2022 22:11, Gedare Bloom wrote: On Wed, Jun 8, 2022 at 1:04 PM Sebastian Huber wrote: On 08/06/2022 17:40, Gedare Bloom wrote: Hm. This looks ok, but it also seems to be a bit of an awkward requirement. Is this only relevant for the tm27 test? I hijacked the tm27 support to add an A

Re: [PATCH 0/5] Fix gcc 12 warnings

2022-06-08 Thread Chris Johns
Thank you for posting fixes for these warnings. I opened https://devel.rtems.org/ticket/4662 to track this issue. Can the commit messages please be updated to includes "Updates #4662". Thanks Chris On 8/6/2022 11:34 pm, Matthew Joyce wrote: > From: Matt Joyce > > Hello, > > These patches fix

Re: [gcc] Enable TLS support for RTEMS in libstdc++

2022-06-08 Thread Chris Johns
On 9/6/2022 12:18 am, Sebastian Huber wrote: > On 08/06/2022 16:11, Joel Sherrill wrote: >> On Wed, Jun 8, 2022 at 8:47 AM Sebastian Huber >> > > wrote: >> If we are to maintain a thread safe C Library, then we have to be >> sure TLS is always supported or

Re: [PATCH] validation: Fix CallWithinISR()

2022-06-08 Thread Gedare Bloom
On Wed, Jun 8, 2022 at 1:04 PM Sebastian Huber wrote: > > On 08/06/2022 17:40, Gedare Bloom wrote: > > Hm. This looks ok, but it also seems to be a bit of an awkward > > requirement. Is this only relevant for the tm27 test? > > I hijacked the tm27 support to add an API for software interrupts. > D

Re: [PATCH] validation: Fix CallWithinISR()

2022-06-08 Thread Sebastian Huber
On 08/06/2022 17:40, Gedare Bloom wrote: Hm. This looks ok, but it also seems to be a bit of an awkward requirement. Is this only relevant for the tm27 test? I hijacked the tm27 support to add an API for software interrupts. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puch

Re: [PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-08 Thread Joel Sherrill
On Wed, Jun 8, 2022, 10:45 AM Gedare Bloom wrote: > Does this code have an upstream? > I tried to find it. Maybe whoever added it has memory of the source. As best I can tell, it is lightly or not maintained reference code. > On Wed, Jun 8, 2022 at 7:35 AM Matthew Joyce > wrote: > > > > Fro

Re: [PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-08 Thread Gedare Bloom
Does this code have an upstream? On Wed, Jun 8, 2022 at 7:35 AM Matthew Joyce wrote: > > From: Matt Joyce > > Specify array size in parameter to match function prototype. This > fixes a new warning in gcc 12. > --- > cpukit/libmd/md5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 1/1] Newlib01: Add tests for rand() and lrand48()

2022-06-08 Thread Gedare Bloom
ok On Wed, Jun 8, 2022 at 3:02 AM Matthew Joyce wrote: > > From: Matt Joyce > > Check that the state of rand() and lrand48() is thread-specific, > that they are properly initialized, and return the expected > sequence of pseudo-random numbers for default seed values. > --- > testsuites/libtests

Re: [PATCH] validation: Fix CallWithinISR()

2022-06-08 Thread Gedare Bloom
Hm. This looks ok, but it also seems to be a bit of an awkward requirement. Is this only relevant for the tm27 test? On Tue, Jun 7, 2022 at 8:01 AM Sebastian Huber wrote: > > Some BSPs require that Clear_tm27_intr() is called in the interrupt > service routine. > > Update #3269. > --- > testsuit

Re: [PATCH] testsuite/libtests: Add exit03 to test exit() with C++

2022-06-08 Thread Gedare Bloom
ok On Tue, Jun 7, 2022 at 10:49 PM wrote: > > From: Chris Johns > > Updates #4661 > --- > spec/build/testsuites/libtests/exit03.yml | 20 > spec/build/testsuites/libtests/grp.yml| 2 + > testsuites/libtests/exit03/exit03.doc | 11 ++ > testsuites/libtests/exit03/exit03.scn

Re: [gcc] Enable TLS support for RTEMS in libstdc++

2022-06-08 Thread Sebastian Huber
On 08/06/2022 16:11, Joel Sherrill wrote: On Wed, Jun 8, 2022 at 8:47 AM Sebastian Huber > wrote: On 08/06/2022 15:39, Joel Sherrill wrote: > Is TLS actually supported on all targets except MIPS? I only added MIPS since this target has

Re: [gcc] Enable TLS support for RTEMS in libstdc++

2022-06-08 Thread Joel Sherrill
On Wed, Jun 8, 2022 at 8:47 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 08/06/2022 15:39, Joel Sherrill wrote: > > Is TLS actually supported on all targets except MIPS? > > I only added MIPS since this target has a fundamental issue with the TLS > support. > > Which target

Re: [gcc] Enable TLS support for RTEMS in libstdc++

2022-06-08 Thread Sebastian Huber
On 08/06/2022 15:39, Joel Sherrill wrote: Is TLS actually supported on all targets except MIPS? I only added MIPS since this target has a fundamental issue with the TLS support. Which target would you also exclude? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Ge

Re: [PATCH] CONTRIBUTING: Warn about white space changes

2022-06-08 Thread Joel Sherrill
This looks good. I would have said "not reformat code" but that's ok. --joel On Wed, Jun 8, 2022 at 7:57 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > --- > CONTRIBUTING.rst | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/CONTRIBUTING.rs

Re: [gcc] Enable TLS support for RTEMS in libstdc++

2022-06-08 Thread Joel Sherrill
Is TLS actually supported on all targets except MIPS? --joel On Wed, Jun 8, 2022 at 1:51 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > libstdc++-v3/ChangeLog: > > * crossconfig.m4 (*-rtems*): Enable TLS support for all RTEMS > targets > except mips. > --- > l

[PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-08 Thread Matthew Joyce
From: Matt Joyce Specify array size in parameter to match function prototype. This fixes a new warning in gcc 12. --- cpukit/libmd/md5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmd/md5.c b/cpukit/libmd/md5.c index 4c909f37a0..5e3a100c7b 100644 --- a/cpukit/li

[PATCH 4/5] testsuites/libtests/POSIX/free.c: fix warning

2022-06-08 Thread Matthew Joyce
From: Matt Joyce This change fixes a new warning in gcc 12. --- testsuites/libtests/POSIX/free.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuites/libtests/POSIX/free.c b/testsuites/libtests/POSIX/free.c index 8550eaa85c..6bc961b968 100644 --- a/testsuites/libtests/P

[PATCH 5/5] testsuites/libtests/malloctest: fix warning

2022-06-08 Thread Matthew Joyce
From: Matt Joyce Removed problematic free() and several unnecessary print statement parameters. This fixes new warnings in gcc 12. --- testsuites/libtests/malloctest/init.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/testsuites/libtests/malloctest/init.

[PATCH 1/5] libcsupport/src/__times.c: fix warning

2022-06-08 Thread Matthew Joyce
From: Matt Joyce Define _LIBC to access prototype for _times() function. This fixes a new warning in gcc 12. --- cpukit/libcsupport/src/__times.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpukit/libcsupport/src/__times.c b/cpukit/libcsupport/src/__times.c index 629a7bc633..1a994ad

[PATCH 0/5] Fix gcc 12 warnings

2022-06-08 Thread Matthew Joyce
From: Matt Joyce Hello, These patches fix several new warnings which appeared with gcc 12. Sincerely, Matt Matt Joyce (5): libcsupport/src/__times.c: fix warning cpukit/posix/src/_execve.c: fix warning cpukit/libmd/md5.c: fix warning testsuites/libtests/POSIX/free.c: fix warning tes

[PATCH 2/5] cpukit/posix/src/_execve.c: fix warning

2022-06-08 Thread Matthew Joyce
From: Matt Joyce Define _LIBC to access prototype for _execve() function. This fixes a new warning in gcc 12. --- cpukit/posix/src/_execve.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpukit/posix/src/_execve.c b/cpukit/posix/src/_execve.c index 2858d13082..29c4fe8fcf 100644 --- a/

[PATCH] CONTRIBUTING: Warn about white space changes

2022-06-08 Thread Sebastian Huber
--- CONTRIBUTING.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 79a42db1..36cd91de 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -279,6 +279,12 @@ original FreeBSD code. Rules for Modifying FreeBSD Source =

Re: [PATCH v2] Use global stdio streams for all configurations

2022-06-08 Thread Sebastian Huber
On 08/06/2022 11:43, Sebastian Huber wrote: The _REENT_GLOBAL_STDIO_STREAMS was introduced by commit 668a4c8722090fffd10869dbb15b879651c1370d in 2017. Since then it was enabled by default for RTEMS. Recently, the option was enabled for Cygwin which previously used an alternative implementation

[PATCH v2] Use global stdio streams for all configurations

2022-06-08 Thread Sebastian Huber
The _REENT_GLOBAL_STDIO_STREAMS was introduced by commit 668a4c8722090fffd10869dbb15b879651c1370d in 2017. Since then it was enabled by default for RTEMS. Recently, the option was enabled for Cygwin which previously used an alternative implementation to use global stdio streams. In Newlib, the s

Re: [PATCH 3/7] TFTPFS: Restore tftpDriver.c

2022-06-08 Thread Sebastian Huber
On 06/06/2022 17:34, Joel Sherrill wrote: On Mon, Jun 6, 2022 at 9:02 AM Frank Kühndel > wrote: Hello Joel, *From: *"Joel Sherrill" mailto:j...@rtems.org>> *To:

[PATCH 0/1] Newlib01: Add tests for rand() and lrand48()

2022-06-08 Thread Matthew Joyce
From: Matt Joyce Hello, This patch adds tests for rand() and lrand48(). It checks to ensure their state is thread-specific, that they are properly initialized, and return the expected sequence for default seed values. Sincerely, Matt Matt Joyce (1): Newlib01: Add tests for rand() and lrand4

[PATCH 1/1] Newlib01: Add tests for rand() and lrand48()

2022-06-08 Thread Matthew Joyce
From: Matt Joyce Check that the state of rand() and lrand48() is thread-specific, that they are properly initialized, and return the expected sequence of pseudo-random numbers for default seed values. --- testsuites/libtests/newlib01/init.c | 50 +++ testsuites/libtests

AW: AW: AW: [PATCH] kern_tc.c: Update pps_event() for uniprocessor configurations

2022-06-08 Thread Gabriel.Moyano
> I don't know why there is this "if" in the code. I will ask on a FreeBSD > mailing list. > > >>> I think it is for the case that th_generation has changed in between > >>> saving the th and th_counter. If this happens pps->capgen is set to > >>> 0 and later pps_event() returns ear